Fix template chart to work with spiffe and with dapr 1.14.4#57
Conversation
Signed-off-by: Luigi Rende <luigi.rende@assistdigital.com>
|
@luigirende thanks for submitting this PR, we should update the charts to use the latest version too. Are you aiming to use 1.14.4? |
salaboy
left a comment
salaboy
left a comment
There was a problem hiding this comment.
@luigirende I am happy to merge this, if we remove the istio label.
Signed-off-by: luigirende <luigirende@gmail.com>
|
@salaboy removed the useless label about istio, sorry it has been a typo |
|
Thanks! I will merge and test |
@salaboy I'm using this version for 1.15.3 version too |
|
@luigirende can you update this PR to include the version that you are using? merging for 1.14.x doesn't make too much sense |
Signed-off-by: salaboy <Salaboy@gmail.com>
Signed-off-by: salaboy <Salaboy@gmail.com>
|
Thanks @luigirende and @salaboy! Looks like the Helm unit-tests are failing and preventing the Helm chart from being published. I've created #61 to fix. |
3 participants
This PR change the chart template to fix the issue #56 and to be compatible with dapr 1.14.4. In fact the actual version of the chart when use the image tag to 1.14.4 there is an issue about the certs.