WIP [Tracing] Adding semantic convention and pubsub producer/consumer spans#9213
Closed
salaboy wants to merge 1 commit into
Closed
WIP [Tracing] Adding semantic convention and pubsub producer/consumer spans#9213salaboy wants to merge 1 commit into
salaboy wants to merge 1 commit into
Conversation
Signed-off-by: salaboy <Salaboy@gmail.com>
08224b8 to
f308c93
Compare
Collaborator
|
This pull request has been automatically marked as stale because it has not had activity in the last 90 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Collaborator
|
This pull request has been automatically closed because it was marked stale with no further activity for 7 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Author
|
folks I really think this needs to be re-open or at least add a link to another PR to track this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds producer and consumer spans for PubSub interactions as well as semantic conventions for Dapr workflows. This helps tooling in the observability space to group Dapr attributes together. It also help other Dapr components to align on how we define attributes for traces and spans.
Changes created by Kasper from Dash0, but I created the PR to review and push forward.
Issue reference
Related to:
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: