Skip to content

Bundle Dapr.SecretsManagement.* and Dapr.StateManagement.* into single NuGet packages#1827

Merged
WhitWaldo merged 1 commit into
masterfrom
copilot/combine-secrets-management-packages
May 21, 2026
Merged

Bundle Dapr.SecretsManagement.* and Dapr.StateManagement.* into single NuGet packages#1827
WhitWaldo merged 1 commit into
masterfrom
copilot/combine-secrets-management-packages

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 21, 2026

Description

Follows the bundling pattern established for Dapr.Workflow in #1824. Previously dotnet pack emitted standalone Dapr.SecretsManagement.Abstractions, Dapr.SecretsManagement.Runtime, Dapr.StateManagement.Abstractions, and Dapr.StateManagement.Runtime packages alongside their aggregator packages.

The Dapr.SecretsManagement and Dapr.StateManagement aggregator projects already embed the child assemblies (under lib/<tfm>/) and source generators (under analyzers/dotnet/cs/), so only the children needed to be opted out of packing.

  • Children marked non-packable — added <IsPackable>false</IsPackable> plus PackageId/Title/Description metadata to the four child csproj files, matching the Dapr.Workflow.Abstractions / Dapr.Workflow.Grpc style.
  • No aggregator changesDapr.SecretsManagement.csproj and Dapr.StateManagement.csproj already collect child outputs via TargetsForTfmSpecificContentInPackage.

Result of dotnet pack all.sln -c Release: only Dapr.SecretsManagement.<ver>.nupkg and Dapr.StateManagement.<ver>.nupkg are produced, each containing lib/{net8.0,net9.0,net10.0}/{Abstractions,Runtime}.dll and analyzers/dotnet/cs/*.Generators.dll.

Issue reference

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests (existing Dapr.SecretsManagement.Runtime.Test — 39 tests, and Dapr.StateManagement.Test — 54 tests, all pass on net8/net9/net10)
  • Extended the documentation

@WhitWaldo WhitWaldo marked this pull request as ready for review May 21, 2026 18:33
@WhitWaldo WhitWaldo requested review from a team as code owners May 21, 2026 18:33
@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.47%. Comparing base (0621b54) to head (2e1c6da).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1827      +/-   ##
==========================================
+ Coverage   63.46%   63.47%   +0.01%     
==========================================
  Files         312      312              
  Lines        9279     9279              
  Branches     1101     1101              
==========================================
+ Hits         5889     5890       +1     
- Misses       3129     3130       +1     
+ Partials      261      259       -2     
Flag Coverage Δ
net10.0 63.46% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WhitWaldo WhitWaldo merged commit 0c6819f into master May 21, 2026
918 of 928 checks passed
@WhitWaldo WhitWaldo deleted the copilot/combine-secrets-management-packages branch May 21, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants