Add Last to the func name GetActivityByName and GetWorkflowByName & GetLastChildWorkflowByName#105
Merged
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
JoshVanL
approved these changes
May 19, 2026
There was a problem hiding this comment.
Pull request overview
Renames two propagation API methods to make the "returns the last match" semantics explicit in their names: GetWorkflowByName → GetLastWorkflowByName and GetActivityByName → GetLastActivityByName. Doc comments and all callers in the tests are updated to match.
Changes:
- Rename
PropagatedHistory.GetWorkflowByNametoGetLastWorkflowByNameandWorkflowResult.GetActivityByNametoGetLastActivityByName, updating doc comments. - Update all test functions and call sites in
api/propagation_test.goto use the new names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/propagation.go | Renames the two singular getters and updates the related doc comments. |
| api/propagation_test.go | Updates test names and call sites to the new method names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
JoshVanL
approved these changes
May 19, 2026
cicoyle
changed the title
3 tasks
siri-varma
added a commit
to siri-varma/java-sdk
that referenced
this pull request
May 20, 2026
Address review feedback on dapr#1739: replace user-facing PropagatedHistoryChunk with WorkflowResult, mirroring dapr/durabletask-go#105. Adds typed ActivityResult and ChildWorkflowResult value types, and getLast*ByName / get*ByName lookups so callers don't walk raw history events. Renames getWorkflowByName to getLastWorkflowByName for symmetry with the new methods. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
This was referenced May 20, 2026
dapr-bot
pushed a commit
to dapr/java-sdk
that referenced
this pull request
May 22, 2026
* Apply suggestions from code review Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Refactor BookTripWorkflow to use CompensationHelper Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Add CompensationHelper class for managing compensations Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Await cancellation activities in BookTripWorkflow Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Add the new changes Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * fix violations Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Fix helper Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Modify readme Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Modify readme Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Modify readme Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Update copyright year and improve comment clarity Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Update copyright year to 2026 Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Update HistoryPropagationScope.java Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Update ActivityHistoryPropagationTest.java Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Change to 2026 Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Fix things Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Potential fix for pull request finding Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Hide chunk concept; expose WorkflowResult with typed lookups Address review feedback on #1739: replace user-facing PropagatedHistoryChunk with WorkflowResult, mirroring dapr/durabletask-go#105. Adds typed ActivityResult and ChildWorkflowResult value types, and getLast*ByName / get*ByName lookups so callers don't walk raw history events. Renames getWorkflowByName to getLastWorkflowByName for symmetry with the new methods. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Bump copyright year to 2026 on PR files Address review feedback (#1739): the new files in this PR were stamped 2025 - update them to 2026 to match the year the work is landing. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Surface PropagatedHistoryException at parse boundaries Address review feedback (#1739): - TaskOrchestrationExecutor.execute: catch PropagatedHistoryException ahead of the generic Exception branch so a malformed payload is logged as a parse failure (not just "unhandled exception") before failing the context. - TaskActivityExecutor.execute: wrap PropagatedHistory.fromProto in a try/catch and rethrow PropagatedHistoryException with the activity name in the message, so the caller sees a typed parse failure rather than something that looks like a generic protobuf error. Adds tests for both paths driving a malformed PropagatedHistory chunk through each executor. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Address comments Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> --------- Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
siri-varma
added a commit
to dapr/java-sdk
that referenced
this pull request
May 22, 2026
* Apply suggestions from code review * Refactor BookTripWorkflow to use CompensationHelper * Add CompensationHelper class for managing compensations * Await cancellation activities in BookTripWorkflow * Add the new changes * fix violations * Fix helper * Modify readme * Modify readme * Modify readme * Update copyright year and improve comment clarity * Update copyright year to 2026 * Update HistoryPropagationScope.java * Update ActivityHistoryPropagationTest.java * Change to 2026 * Fix things * Potential fix for pull request finding * Hide chunk concept; expose WorkflowResult with typed lookups Address review feedback on #1739: replace user-facing PropagatedHistoryChunk with WorkflowResult, mirroring dapr/durabletask-go#105. Adds typed ActivityResult and ChildWorkflowResult value types, and getLast*ByName / get*ByName lookups so callers don't walk raw history events. Renames getWorkflowByName to getLastWorkflowByName for symmetry with the new methods. * Bump copyright year to 2026 on PR files Address review feedback (#1739): the new files in this PR were stamped 2025 - update them to 2026 to match the year the work is landing. * Surface PropagatedHistoryException at parse boundaries Address review feedback (#1739): - TaskOrchestrationExecutor.execute: catch PropagatedHistoryException ahead of the generic Exception branch so a malformed payload is logged as a parse failure (not just "unhandled exception") before failing the context. - TaskActivityExecutor.execute: wrap PropagatedHistory.fromProto in a try/catch and rethrow PropagatedHistoryException with the activity name in the message, so the caller sees a typed parse failure rather than something that looks like a generic protobuf error. Adds tests for both paths driving a malformed PropagatedHistory chunk through each executor. * Address comments --------- (cherry picked from commit d87a84c) Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.