Adds ListInstanceIDs & GetInstanceHistory APIs#51
Merged
Conversation
Implements these new methods implementing dapr/proposals#93 Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
instance-list-get-history
branch
from
6471393 to
ab1112c
Compare
Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
requested changes
Nov 6, 2025
|
|
||
| rows, err := be.db.Query( | ||
| ctx, | ||
| "SELECT EventPayload FROM History WHERE InstanceID = $1 ORDER BY SequenceNumber ASC", |
There was a problem hiding this comment.
I think we are missing the pgSize and continuationToken here and for the list()... unless I'm missing it?
Author
There was a problem hiding this comment.
This backend implementation is only used for durabletask CI testing, so I don't think it matters too much. We have more robust testing on the Dapr side which is what will be used.
There was a problem hiding this comment.
oh yes, very true. thats fine to leave out I suppose
Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements these new methods implementing dapr/proposals#93