History Signing#35
Merged
Merged
Conversation
Extends the backend service proto with messages needed for chain-of-custody signing of workflow history events. Each orchestrator execution signs the new event range and chains to the previous signature. Certificates are deduplicated in a separate table and referenced by index. - SigningCertificate: stores DER-encoded X.509 certificate per identity - HistorySignature: signing metadata covering a contiguous event range, linked via previousSignatureDigest to form a verifiable chain - WorkflowStateMetadata: extended with signatureLength and signingCertificateLength fields Proposal: dapr/proposals#102 Signed-off-by: joshvanl <me@joshvanl.dev>
There was a problem hiding this comment.
Pull request overview
Extends backend_service.proto with new proto messages and metadata fields to support chain-of-custody signing for workflow history, including signature chaining and certificate de-duplication.
Changes:
- Extend
WorkflowStateMetadatawith counts for stored history signatures and signing certificates. - Add
SigningCertificateto store X.509 cert material once and reference it by index. - Add
HistorySignatureto record per-range digests and signatures chained to a previous signature digest.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: joshvanl <me@joshvanl.dev>
There was a problem hiding this comment.
Pull request overview
Extends the backend service protobuf schema to support chain-of-custody signing for workflow history by introducing signature metadata messages and tracking counts in workflow state metadata.
Changes:
- Add
signatureLengthandsigningCertificateLengthtoWorkflowStateMetadatafor tracking stored signing artifacts. - Introduce
SigningCertificatefor deduplicated certificate (chain) storage referenced by index. - Introduce
HistorySignatureto represent signatures over contiguous history event ranges with chaining to the prior signature.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
cicoyle
approved these changes
Mar 26, 2026
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends the backend service proto with messages needed for chain-of-custody signing of workflow history events. Each orchestrator execution signs the new event range and chains to the previous signature. Certificates are deduplicated in a separate table and referenced by index.
Proposal: dapr/proposals#102