chore: Support taskExecutionId#738
Conversation
|
Drafting this until the upstream changes are merged and the deps vendored |
1627eee to
60d9c76
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #738 +/- ##
==========================================
- Coverage 62.52% 57.16% -5.36%
==========================================
Files 56 58 +2
Lines 4139 4436 +297
==========================================
- Hits 2588 2536 -52
- Misses 1425 1763 +338
- Partials 126 137 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2c78378 to
b5283c5
Compare
|
Why codecov/project is failing? It is comparing with a very old commit (6c59092). Where is it configured? |
41731b7 to
570cb3b
Compare
|
I wouldn't worry too much about the pretty arbitary codecov, I can see the config hasn't been updated for 5 years in the root of the repo. |
570cb3b to
a0e0f8b
Compare
2c54ea6 to
f8f2d9d
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Javier Aliaga <javier@diagrid.io>
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Mike Nguyen <hey@mike.ee>
Signed-off-by: Mike Nguyen <hey@mike.ee>
f8f2d9d to
33aa584
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
224740a to
0f8cf61
Compare
Signed-off-by: Javier Aliaga <javier@diagrid.io>
0f8cf61 to
2b6eb66
Compare
|
@mikeee this is ready and running with rc3 |
There was a problem hiding this comment.
Could you please open a quick issue if you don't have time to add the new Alpha2 implementation of the conversation api jsut so we're not ignoring the planned deprecation entirelyCould you please open a quick issue if you don't have time to add the new Alpha2 implementation of the conversation api jsut so we're not ignoring the planned deprecation entirely
|
@mikeee can we merge this? |
Description
Support new field taskExecutionId
Implements:
Depends on:
Issue reference
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: