Backport 1746 to release 1.18 v2#1749
Closed
javier-aliaga wants to merge 3 commits into
Closed
Conversation
Signed-off-by: Dapr Bot <daprweb@microsoft.com>
…-bom (dapr#1744) (dapr#1745) The release script bumps the dapr.sdk.version property in all reactor POMs (including dapr-spring-bom) before bumping the standalone BOMs. The later 'mvn versions:set -f dapr-spring/dapr-spring-bom/pom.xml' runs in single-POM mode (no reactor) and tries to resolve the import dapr-sdk-bom at the new version, which is not yet installed. Install sdk-bom into the local repo between the two BOM updates so the import resolves. (cherry picked from commit 2c038f4) Signed-off-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
…1608) (dapr#1746) Adds optional deadLetterTopic parameter to the streaming subscribe APIs on DaprPreviewClient / DaprClientImpl, wiring it through to the SubscribeTopicEventsRequestInitialAlpha1.dead_letter_topic proto field. New overloads: - subscribeToEvents(pubsubName, topic, deadLetterTopic, listener, type) - subscribeToTopic(pubsubName, topic, deadLetterTopic, type) - subscribeToTopic(pubsubName, topic, deadLetterTopic, type, metadata) Existing methods delegate to the new ones with a null deadLetterTopic, and the field is only set on the request when a non-empty value is provided. Adds unit tests covering both presence and absence of the field on the gRPC initial frame. Fixes: dapr#1608 Signed-off-by: Siri Varma Vegiraju <s_vegiraju@apple.com> Co-authored-by: Siri Varma Vegiraju <s_vegiraju@apple.com> (cherry picked from commit 93c5acc)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please explain the changes you've made
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: