fix(grpc): apply maxBodySizeMb to Dapr sidecar (--max-body-size)#776
fix(grpc): apply maxBodySizeMb to Dapr sidecar (--max-body-size)#776
Conversation
…max-body-size) Signed-off-by: Siraddeen <sircoil17@gmail.com>
65fdd64 to
c38e38a
Compare
|
@Siraddeen Perhaps you're missing some commits, but I don't show any changes except to the test logic here. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #776 +/- ##
============================================
- Coverage 100.00% 25.98% -74.02%
============================================
Files 1 138 +137
Lines 6 3721 +3715
Branches 1 564 +563
============================================
+ Hits 6 967 +961
- Misses 0 2710 +2710
- Partials 0 44 +44 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Siraddeen <sircoil17@gmail.com>
272566c to
93cf702
Compare
|
Thanks for the feedback. The fix ensures that I’ve also added integration tests covering:
Please let me know if you'd like the fix split or adjusted further. |
…ests Signed-off-by: Siraddeen <sircoil17@gmail.com>
9ac1a18 to
6911fd1
Compare
|
Thanks for your patience. I re-ran the full E2E gRPC test suite in a Linux environment (WSL) to match the CI setup, and all tests are now passing. The issue I encountered earlier was due to local Windows networking differences rather than the implementation itself. The fix ensures that Please let me know if you'd like any further adjustments. |
|
This is the repository for just the JS SDK - we have no interaction with initializing the sidecar (except with regards to the sidecar we spin up for e2e testing). We don't need tests that validate that the runtime works with the flags - they have their own test suite that validates that. Your fix seems to readily pass a missing parameter to the sidecar for testing purposes, which is great, because it means that E2E tests will pass, as you've observed. But they were already passing and this isn't what #735 reports. #735 reports that when utilizing the service invocation methods (and perhaps others), the gRPC client in the SDK itself is not honoring a configured receive limit increase. Your PR doesn't change any of the SDK logic itself - just the test harness. While it might be a useful PR unto itself so the E2E tests properly work, you're not actually changing the SDK and fixing the reported issue. Rather, if you'd like to take a stab at tackling #735, you're certainly invited to at which point I'd be happy to review this again. |
Signed-off-by: Siraddeen <sircoil17@gmail.com>
|
Updated the implementation to enforce maxBodySizeMb at the SDK level. The validation is now performed in the gRPC invoker after serialization, This aligns with the issue description, where the SDK itself should honor |
Summary
Fixes an issue where
maxBodySizeMbwas not correctly applied to the Dapr sidecar receive limit.Changes
--max-body-sizeto daprd whenmaxRequestSizeMbis definedTests
Fixes #735