fix(mcp): keep proposal up to date with changes#106
Open
sicoyle wants to merge 2 commits into
Open
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
sicoyle
changed the title
There was a problem hiding this comment.
Pull request overview
Updates the MCPServer proposal document to incorporate feedback from dapr/dapr#9685, including a revised endpoint schema and an expanded middleware model.
Changes:
- Restructures
spec.endpointexamples to use transport-specific nested objects (sse,streamableHTTP,stdio) instead of atransport+targetpattern. - Reworks middleware from single
beforeCall/afterCallworkflow names to ordered hook pipelines (beforeCallTool,afterCallTool, etc.) and adds concrete middleware scenarios. - Updates the proposed Go API types in the document to reflect the new endpoint and middleware shapes.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Samantha Coyle <sam@diagrid.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updating proposal based on feedback here in PR: dapr/dapr#9685