Skip to content

SafetyFinder: Stop attacking when moving to safety#111

Merged
Pablete1234 merged 2 commits intodarkbot-reloaded:masterfrom
do-gamer:safety_finder_stop_attack
Feb 8, 2026
Merged

SafetyFinder: Stop attacking when moving to safety#111
Pablete1234 merged 2 commits intodarkbot-reloaded:masterfrom
do-gamer:safety_finder_stop_attack

Conversation

@do-gamer
Copy link
Contributor

@do-gamer do-gamer commented Jan 29, 2026

This is from Discrord "#feature-request-list" channel:

  • When running, stop shooting npc

Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice in concept, but it may need some extra thought.
In particular when the escape mode is sight (ie: you have not been attacked, and you're only running because an enemy showed up near you), and you have the stopRunningNoSight config set, the bot will just run back towards the npc if the enemy goes away, but will not be attacking anymore (and it may take a bit for it to re-try shooting).
If the bot is "just close enough" to the enemy that it keeps "dancing" to get closer to the npc, then start running, and back, this will be stopping attacks all the time when it could have slowly dragged the npc away.

TLDR: consider that when you're running in escape mode sight, and you have stopRunningNoSight enabled, you should only stop attacking when you're significantly away from the npc, or maybe not even stop at all.

@do-gamer
Copy link
Contributor Author

do-gamer commented Feb 8, 2026

or maybe not even stop at all.

Yes, this make a sense.

@do-gamer do-gamer requested a review from Pablete1234 February 8, 2026 14:47
@Pablete1234 Pablete1234 merged commit 359b80a into darkbot-reloaded:master Feb 8, 2026
1 check passed
@do-gamer do-gamer deleted the safety_finder_stop_attack branch February 9, 2026 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants