-
Notifications
You must be signed in to change notification settings - Fork 0
cicd: fix issues #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -21,6 +21,8 @@ jobs: | |||
| generate: | ||||
| name: Check generated code | ||||
| runs-on: ubuntu-24.04 | ||||
| env: | ||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||||
| steps: | ||||
| - uses: actions/checkout@v6 | ||||
|
|
||||
|
|
@@ -63,6 +65,8 @@ jobs: | |||
| name: Lint | ||||
| runs-on: ubuntu-24.04 | ||||
| timeout-minutes: 45 | ||||
| env: | ||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||||
|
Comment on lines
+68
to
+69
|
||||
| steps: | ||||
| - uses: actions/checkout@v6 | ||||
|
|
||||
|
|
@@ -90,6 +94,8 @@ jobs: | |||
| vuln: | ||||
| name: Vulnerability scan | ||||
| runs-on: ubuntu-24.04 | ||||
| env: | ||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||||
|
Comment on lines
+97
to
+98
|
||||
| steps: | ||||
| - uses: actions/checkout@v6 | ||||
|
|
||||
|
|
@@ -119,6 +125,8 @@ jobs: | |||
| name: Unit tests | ||||
| runs-on: ubuntu-24.04 | ||||
| timeout-minutes: 60 | ||||
| env: | ||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||||
|
Comment on lines
+128
to
+129
|
||||
| steps: | ||||
| - uses: actions/checkout@v6 | ||||
|
|
||||
|
|
@@ -149,7 +157,7 @@ jobs: | |||
| -timeout=45m \ | ||||
| -race \ | ||||
| -coverprofile=coverage.out \ | ||||
| ./internal/... ./cmd/tilbo/... ./cmd/tilbo-daemon/... | ||||
| ./internal/... ./cmd/tilbo/... | ||||
|
|
||||
| - name: Write coverage summary | ||||
| if: always() | ||||
|
|
@@ -191,6 +199,8 @@ jobs: | |||
| bench: | ||||
| name: Benchmarks | ||||
| runs-on: ubuntu-24.04 | ||||
| env: | ||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||||
|
Comment on lines
+202
to
+203
|
||||
| steps: | ||||
| - uses: actions/checkout@v6 | ||||
|
|
||||
|
|
@@ -237,6 +247,7 @@ jobs: | |||
| CGO_ENABLED: "0" | ||||
| GOOS: linux | ||||
| GOARCH: ${{ matrix.goarch }} | ||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true | ||||
|
||||
| FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow already sets
FORCE_JAVASCRIPT_ACTIONS_TO_NODE24at the top-levelenv:(applies to all jobs). This job-levelenv:block is redundant; consider removing it unless this job needs to override the workflow default.