Skip to content

ENG-467 Add Support Nixmac settings link#114

Open
Farhan (fkb032) wants to merge 1 commit into
developfrom
eng-467-support-nixmac-link
Open

ENG-467 Add Support Nixmac settings link#114
Farhan (fkb032) wants to merge 1 commit into
developfrom
eng-467-support-nixmac-link

Conversation

@fkb032
Copy link
Copy Markdown
Contributor

@fkb032 Farhan (fkb032) commented May 8, 2026

Summary

Adds a lightweight Support Nixmac row to Settings > General. The row keeps the visible action compact (Open) while using a specific accessible label (Open Support Nixmac) and opens the public support page at https://nixmac.com/support.

Also extracts the existing external-link fallback into a small helper so the privacy-policy link and support link share the same Tauri-shell fallback behavior.

Test Plan

  • bun --cwd apps/native test:unit -- src/components/widget/settings/general-tab.test.tsx
  • Scoped oxlint on changed files with minimal config: bunx oxlint -c <temp-empty-json> src/components/widget/settings/general-tab.tsx src/components/widget/settings/general-tab.test.tsx
  • bun --cwd apps/native build currently fails on existing apps/native/src/components/widget/controls/directory-picker.test.tsx TypeScript errors unrelated to this PR.

Docs

  • Docs updated (companion PR in darkmatter/nixmac-web: #___)
  • No docs update needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

Warnings
⚠️ Please assign this PR to someone (usually yourself).

📋 PR Overview

Lines changed 101 (+92 / -9)
Files 1 added, 1 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests yes (1)
package.json touched no
Cargo.toml touched no
Infra / CI touched no

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 17.9% 17.9% 28.2% 52.9%

Generated by 🚫 dangerJS against beaad9a

@fkb032 Farhan (fkb032) force-pushed the eng-467-support-nixmac-link branch 2 times, most recently from ffbcd17 to 4be869d Compare May 8, 2026 06:11
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

There were some issues that rebasing the branch has solved (sorry for the force push). The branch is ready for merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants