feat: Add channel registration check before searching to prevent erro…#134
Open
Scott McMaster (scottmcmaster) wants to merge 4 commits into
Open
feat: Add channel registration check before searching to prevent erro…#134Scott McMaster (scottmcmaster) wants to merge 4 commits into
Scott McMaster (scottmcmaster) wants to merge 4 commits into
Conversation
…rs in search_packages
Scott McMaster (scottmcmaster)
requested review from
Cas Linden (CasLinden),
Copilot and
cooper (czxtm)
Scott McMaster (scottmcmaster)
requested a review
from Farhan (fkb032)
as a code owner
Copilot started reviewing on behalf of
Scott McMaster (scottmcmaster)
May 12, 2026 06:25
View session
Contributor
📋 PR Overview
🔬 Coverage
|
There was a problem hiding this comment.
Pull request overview
This PR adds a pre-check to ensure requested Nix channels are registered in the local nix registry before attempting nix search, preventing tool-call failures when an agent requests non-existent channels.
Changes:
- Added
channel_is_registered()that runsnix registry listand checks for aflake:<channel>entry. - Updated the channel-search loop to skip channels that are not registered (with a warning log).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
nixmac Peekaboo E2E: ❌ FAIL
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rs in search_packages
Summary
This is something I noticed running the automated AI eval tests: The agent frequently tries to search both "nixpkgs" and "nixpkgs-unstable" in the same "search packages" tool call. But if any of the requested channels does not exist, search_packages would return an error. Now we'll make sure to only search registered packages by checking first.
Test Plan
Manually, I forced the agent down both search paths.
Docs