feat: add function to append values to existing multiline or single-line lists while preserving formatting#171
Open
Scott McMaster (scottmcmaster) wants to merge 2 commits into
Open
Conversation
…ine lists while preserving formatting
Copilot started reviewing on behalf of
Scott McMaster (scottmcmaster)
May 16, 2026 02:25
View session
Contributor
📋 PR Overview
🔬 Coverage
|
There was a problem hiding this comment.
Pull request overview
This PR improves Nix list editing in the Tauri native “evolve” layer by appending new list items into an existing list literal without rewriting the whole list, preserving existing multiline formatting and comment structure (removing the prior TODO about formatting loss).
Changes:
- Added
append_values_to_existing_list()to insert new values before the list’s closing bracket while preserving formatting. - Updated
add()to append only missing values to an existing list rather than replacing the full list text. - Expanded/updated unit tests to validate formatting preservation for commented and multiline lists.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the TODO in
edit_nix_fileabout preserving list commenting and formatting.Test Plan
Added/updated unit tests. Also manual testing, for example see the screenshot.
Docs