Fix setup host confirmation preserving selected host#175
Draft
cursor[bot] wants to merge 2 commits into
Draft
Conversation
Co-authored-by: cooper <czxtm@users.noreply.github.com>
Co-authored-by: cooper <czxtm@users.noreply.github.com>
Contributor
📋 PR Overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a setup regression introduced in the recent filesystem/setup flow changes where clicking
Nextcould persist an empty host even though the host dropdown displayed the currently configured host.Bug and impact:
Nextwithout changing the dropdown.saveHost(""), clearing the persisted host and routing the user back into setup with a broken/empty host selection.Root cause:
Selectdisplay was controlled byhost, but theNextbutton persistedselectedHost, which initializes to an empty string and only changes on dropdown interaction.Fix:
selectedHost || host) and disableNextwhen no host is available.Nextwithout changing the dropdown, plus coverage that an empty host cannot be persisted.Test Plan
bun installbun --filter native test:unit -- src/components/widget/steps/setup-step.test.tsxDocs