feat: improve feedback URL configuration and error handling, move DSN to CI#176
Open
Scott McMaster (scottmcmaster) wants to merge 1 commit into
Open
feat: improve feedback URL configuration and error handling, move DSN to CI#176Scott McMaster (scottmcmaster) wants to merge 1 commit into
Scott McMaster (scottmcmaster) wants to merge 1 commit into
Conversation
Contributor
📋 PR Overview
🔬 Coverage
|
Scott McMaster (scottmcmaster)
requested review from
cooper (czxtm) and
Farhan (fkb032)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix/improve send-feedback system, move DSN out of code. There are some additional things that need to be done to finish hooking this up, which I will follow up on offline.
Test Plan
Local run. Also add a bit of unit testing.
Docs