Cas/monaco diffs#62
Conversation
📋 PR Overview
🔬 Coverage
|
…ull file diffs, with scroll to hunks
a6d2cc4 to
284d016
Compare
…c theme from claude design and follow console errors to fix monaco editors with error supression off
35a030c to
4409723
Compare
|
Updated test rersults, WDIO failures are on develop. Vitest — unit project
Vitest totals: 8 files run, 7 pass, 1 fail; 69 tests run, 68 pass, 1 fail. 2 template rows N/A (files don't exist in apps/native scope on this branch). Rust unit tests — by module
Cargo totals: 286 passed, 0 failed, 2 ignored (both noted above — manual-only tests). Playwright E2E
Playwright totals: 2 passed / 0 failed. wdio — Tauri app suitesDebug binary present; ran headless (Option B): Vite on 5173, tauri-wd on 4444, run from
wdio totals: 6 suites: 4 pass, 2 fail. Tests: 11 pass, 2 fail. SummaryCounted at the most natural unit per suite: vitest by file, rust by module, the rest by test/suite as listed.
|
|
About the issue above, I wonder whether it may be related to this: https://linear.app/darkmatterlabs/issue/ENG-472/review-fix-edit-path-resolution-for-nested-flake-configs |
You are right. The file read is lacking awareness of the nested structure and thus lacked the ability to read the changed version of the file. I added a helper in the git module, which fixes only the issue on this branch. The full range of changes needed to support the nested dir may exceed the ticket. I will comment. I also added a preference to prefer the diff tab to the preference settings. Deemed the scope creep worth it. Ran tests again,
Cause of two WDIO failures:
|
|
Hi Cas Linden (@CasLinden)! Thanks for the update. I have tried it again and it seems to be better. Also nice that you also addressed eng-487. However, I am still unsure about the result. When I expand a file, the I see the whole file, like this:
So that I have to scroll a fair bit to see the actual change. The view does some cool things (keeps blocks as a kind of "header" to see context as you scroll) but I feel like having to scroll through the full file kind of defeats the purpose of a "summary". Perhaps it could show just the hunks (maybe with the old impl) and then with a button expand to the full file. What do you think? Pinging Farhan (@fkb032) and cooper (@czxtm) in case they have an opinion this? |
|
Juanpe Bolívar (@arximboldi) The editor should scroll to the first diff hunk on open. I will see if these is an issue with this. Maybe I could add highlighting to pills when editor expanded and hunk in view, to nudge users towards the interaction. Part of the motivation for this full file impl. is that multiple changes in one file were creating long lists of elements. |



Summary
Replace kibo ui codeblocks for diff display with monaco editor diffs, showing accurate file states and line numbers.
Adds scroll to hunk feature
Adds styles and configuration for monaco editor
Edit 05/05
Test Plan
Make more changes in a file and go to the diff tab, open the diff.
Edit 05/05
rebuild-overlay-panel'sStartingandInfinite Recursion Error, both develop-side)Docs