fix(go60): reverse RH thumb pixel-lookup order#2
Closed
mgabor3141 wants to merge 1 commit into
Closed
Conversation
The first three entries in go60_rh.dts were <57>, <58>, <59> (T3, T2, T1) while the LH uses <54>, <55>, <56> (T1, T2, T3). This caused RH thumb T1 and T3 LEDs to be swapped. Change to <59>, <58>, <57> to match the physical LED strip direction on the right half.
mgabor3141
force-pushed
the
rgb-layer-24.12
branch
11 times, most recently
from
fb0e17c to
2e23dbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first three entries of
pixel-lookupingo60_rh.dtsare<57>, <58>, <59>(T3, T2, T1), but the LH equivalent ingo60_lh.dtsuses<54>, <55>, <56>(T1, T2, T3). The physical LED strip runs in the same direction on both halves, so the RH mapping has T1 and T3 swapped.This changes the RH thumb entries to
<59>, <58>, <57>to match.Tested on a Go60 with a 6-color round-robin test pattern across all 60 keys. All keys light up in the correct positions with the fix applied:
Config used for testing: mgabor3141/go60-zmk-config@86ec300d
Also reported in moergo-sc#36 (comment)