feat(middleware): don't cache responses with a Set-Cookie header#806
Open
u5surf wants to merge 1 commit into
Open
feat(middleware): don't cache responses with a Set-Cookie header#806u5surf wants to merge 1 commit into
u5surf wants to merge 1 commit into
Conversation
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
Owner
|
Can you rebase @u5surf? |
u5surf
force-pushed
the
feat/skip-store-set-cookie
branch
from
June 23, 2026 10:59
fb89e94 to
03fc2ae
Compare
A Set-Cookie response is typically tied to a single user; storing it in a shared cache replays one user's cookie to every subsequent client. Match the default of nginx/Varnish/Fastly/Cloudflare and skip storing such responses (detail=UNCACHEABLE-SET-COOKIE). The exception is an explicit Cache-Control: no-cache="Set-Cookie" directive, which strips the field from the stored response: there is nothing to leak, so the rest of the response is still cached (preserving the existing TestSetCookieNotStored behavior). Closes darkweak#805 Signed-off-by: Y.Horie <u5.horie@gmail.com>
u5surf
force-pushed
the
feat/skip-store-set-cookie
branch
from
June 25, 2026 11:11
03fc2ae to
15bae64
Compare
Owner
|
The opt-in to keep the current behavior is missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Set-Cookie response is typically tied to a single user; storing it in a shared cache replays one user's cookie to every subsequent client. Match the default of nginx/Varnish/Fastly/Cloudflare and skip storing such responses (detail=UNCACHEABLE-SET-COOKIE).
Closes #805