fix(middleware): freshen stored response on 304 revalidation#821
Open
u5surf wants to merge 1 commit into
Open
Conversation
When a revalidation returns 304 (Not Modified), the stored response was reused but never updated with the 304's header fields, so its freshness metadata (Date, Cache-Control) stayed stale and every later request re-revalidated — the validation was wasted. Merge the 304's headers into the stored response and re-store it through a throwaway writer (leaving the client-facing response untouched) so the entry becomes fresh again, as required by RFC 9111 §4.3.4 (§3.2 update semantics). Wired into all five revalidation call sites, including the background stale-while-revalidate path. Closes darkweak#809 Signed-off-by: Y.Horie <u5.horie@gmail.com>
✅ Deploy Preview for teal-sprinkles-4c7f14 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a revalidation returns 304 (Not Modified), the stored response was reused but never updated with the 304's header fields, so its freshness metadata (Date, Cache-Control) stayed stale and every later request re-revalidated — the validation was wasted.
Merge the 304's headers into the stored response and re-store it through a throwaway writer (leaving the client-facing response untouched) so the entry becomes fresh again, as required by RFC 9111 §4.3.4 (§3.2 update semantics). Wired into all five revalidation call sites, including the background stale-while-revalidate path.
Closes #809