Skip to content

health action: let someone point at a different ref/repo#411

Open
kevmoo wants to merge 1 commit into
mainfrom
firehose_sync_silly
Open

health action: let someone point at a different ref/repo#411
kevmoo wants to merge 1 commit into
mainfrom
firehose_sync_silly

Conversation

@kevmoo
Copy link
Copy Markdown
Member

@kevmoo kevmoo commented Apr 3, 2026

Allows more experimenting

@kevmoo kevmoo requested a review from mosuem April 3, 2026 01:45
@github-actions github-actions Bot added the type-infra A repository infrastructure change or enhancement label Apr 3, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 3, 2026

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Unused Dependencies ✔️
Package Status
None No packages found to check.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

License Headers ✔️
""
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new GitHub Action for installing ecosystem packages using a composite action and a supporting Bash script. The feedback suggests enhancing the script's robustness by adding error handling with set -eo pipefail, validating the presence of WORKFLOW_REF, and supporting short repository names. Additionally, it is recommended to quote the script path in the action definition to prevent issues with spaces in directory names.

Comment thread .github/actions/install-package/install_package.sh Outdated
Comment thread .github/actions/install-package/action.yml Outdated
@kevmoo kevmoo force-pushed the firehose_sync_silly branch from ad13211 to 1d4da9c Compare April 3, 2026 03:47
@kevmoo kevmoo changed the title Support pinning firehose version and inferring repository in workflows health action: let someone point at a different ref/repo Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant