chore: inline find-comment/create-or-update-comment by kevmoo · Pull Request #413 · dart-lang/ecosystem

kevmoo · 2026-04-16T03:25:49Z

Some Google repos don't like actions from "outside the enterprise"

Other fixes:

Updated the logic to pull in firehose during PRs to THIS repo, so they can be validated together.
- I think we had issues previously before this was NOT done so we landed firehose fixes blind
- Sadly, it's pretty verbose.
Improved the robustness of the github.dart file
- General wise handling of null bits to give helpful errors

Partially addresses #395

Some Google repos don't like actions from "outside the enterprise"

gemini-code-assist

Code Review

This pull request introduces a new comment CLI tool in pkgs/firehose/bin/comment.dart for finding, creating, and updating GitHub comments. It also extends the GithubApi and LocalGithubApi classes with createComment and updateComment methods. The review feedback identifies improvement opportunities regarding resource management, specifically closing the GithubApi instance to prevent leaks, and enhancing input validation for the issue number in the create-or-update command.

github-actions · 2026-04-16T03:51:08Z

PR Health

License Headers ✔️

// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

Unused Dependencies ✔️

Package	Status
firehose	✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

Changelog Entry ✔️

Package	Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage

⚠️

File	Coverage
pkgs/firehose/lib/src/github.dart	💔 55 % ⬇️ 7 %
pkgs/firehose/lib/src/local_github_api.dart	💔 42 % ⬇️ 13 %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Breaking changes ✔️

Package	Change	Current Version	New Version	Needed Version	Looking good?
firehose	Non-Breaking	0.13.0	0.13.2-wip	0.13.2-wip	✔️

This check can be disabled by tagging the PR with skip-breaking-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package	Leaked API symbol	Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

kevmoo · 2026-04-16T16:24:30Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new comment executable to the firehose package, enabling the management of GitHub comments as a first-class command. The changes include a new CLI tool in bin/comment.dart, updates to the GithubApi to support creating and updating comments, and registration of the new executable in pubspec.yaml. The review feedback suggests enhancing the tool's robustness by implementing better error handling for API failures, validating that comment bodies are not empty, and avoiding potential null pointer exceptions when accessing repository information.

kevmoo · 2026-04-16T16:52:36Z

+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';


~150 lines for bits we don't need to depend on seems worth it.

I do like using dart scripts

kevmoo · 2026-04-16T16:52:55Z


  String? get githubAuthToken => _env['GITHUB_TOKEN'];

+  late final RepositorySlug? _resolvedSlug = _repoSlug ??


This makes error cases a LOT cleaner to understand

kevmoo · 2026-04-16T16:53:10Z

/gemini review

gemini-code-assist

Code Review

This pull request introduces a new comment executable to the firehose package, allowing for the discovery, creation, and updating of GitHub comments directly. It also refactors GithubApi to improve repository slug handling and adds methods for comment management. Critical feedback was provided regarding the incorrect use of the ArgResults API in the new CLI tool, which would cause runtime errors. Additionally, improvements were suggested for error handling in GithubApi by replacing null-assertion operators with a descriptive helper getter for the issue number.

kevmoo · 2026-04-16T17:42:29Z

@mosuem this is ready.

I've ran a few loops through and the comments are still nicely updated

mosuem · 2026-04-17T07:10:55Z


-      - name: Install firehose
+      - name: Install firehose (internal)
+        if: ${{ !inputs.local_debug && github.repository == 'dart-lang/ecosystem' }}


Same as above

mosuem · 2026-04-17T07:11:47Z

+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'dart:io';


I do like using dart scripts

chore: inline find-comment/create-or-update-comment

627a74e

Some Google repos don't like actions from "outside the enterprise"

kevmoo requested a review from mosuem as a code owner April 16, 2026 03:25

github-actions Bot added package:firehose type-infra A repository infrastructure change or enhancement labels Apr 16, 2026

a bit better

0c9187f

gemini-code-assist Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread pkgs/firehose/bin/comment.dart

Comment thread pkgs/firehose/bin/comment.dart Outdated

crazy...but maybe

da4c759

review nits

bf8e57d

gemini-code-assist Bot reviewed Apr 16, 2026

View reviewed changes

Comment thread pkgs/firehose/bin/comment.dart

Comment thread pkgs/firehose/bin/comment.dart Outdated

Comment thread pkgs/firehose/lib/src/github.dart

better!

25317e0

kevmoo commented Apr 16, 2026

View reviewed changes

Comment thread .github/workflows/canary.yaml

kevmoo commented Apr 16, 2026

View reviewed changes

gemini-code-assist Bot reviewed Apr 16, 2026

View reviewed changes

issue, too

c202d12

mosuem reviewed Apr 20, 2026

View reviewed changes

kevmoo mentioned this pull request May 13, 2026

Firehose cannot be run in Flutter DevTools #395

Open

Merge remote-tracking branch 'origin/HEAD' into inline_coment_bits

422c8b0


		String? get githubAuthToken => _env['GITHUB_TOKEN'];

		late final RepositorySlug? _resolvedSlug = _repoSlug ??

Conversation

kevmoo commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Health

Uh oh!

kevmoo commented Apr 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

mosuem Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

kevmoo Apr 16, 2026

Choose a reason for hiding this comment

Uh oh!

kevmoo commented Apr 16, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kevmoo commented Apr 16, 2026

Uh oh!

Uh oh!

Uh oh!

mosuem Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mosuem Apr 17, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

kevmoo commented Apr 16, 2026 •

edited

Loading

github-actions Bot commented Apr 16, 2026 •

edited

Loading