Explain goal and usage of the table 'Package publishing'.#417
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds a descriptive message to the package publishing comment in firehose.dart to guide users with publishing permissions, alongside minor code formatting improvements. The review feedback correctly identifies a grammatical typo in the new description string ('this links' instead of 'these links') and provides a code suggestion to correct it.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
PR HealthAPI leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with
Coverage
|
| File | Coverage |
|---|---|
| pkgs/firehose/lib/firehose.dart | 💔 0 % ⬇️ NaN % |
This check for test coverage is informational (issues shown here will not fail the PR).
This check can be disabled by tagging the PR with skip-coverage-check.
|
About formatting failure. This is the bot error: The error does not disappear even after running locally: Dart version on bot: My local Dart version: I also tried older versions of Dart. Is there more than one flavor of formatting? I suspect yes, because my local I reviewed both CONTRIBUTING.md and Dart style guide and did not find guidance. Will appreciate hints. |
|
@gspencergoog , addressing you feedback about clarity of the comment. |
Another clue is that the "dev" build succeeds where the "stable" build does not: https://github.com/dart-lang/ecosystem/actions/runs/26720042346/job/78745344376?pr=417 I'm guessing that Dart format changed between the stable and the beta (dev) build. It would be good to figure out what changed, and, if possible, reorganize the offending code so both versions pass (by adding end of line comments, or some other innocuous change). This is annoying, but I think if we just ignore it, then other people will keep running into it until the next release of Flutter to stable. I was a little surprised that we use "dev" and not "beta". Maybe that's the beta build anyhow, though, because I thought we stopped releasing dev a long time ago. Anyhow, that could be another source of difference: if the dev build is really an old build that isn't being released anymore, then it also might have a different dart format. |
Good observations. Thanks. I will allow a reviewer from dart-lang to decide if it is ok to ignore the failures. |
Ahh, but the one thing I didn't observe was that this was in the |
Contributes to google/A2UI#1383