Skip to content

Explain goal and usage of the table 'Package publishing'.#417

Open
polina-c wants to merge 8 commits into
dart-lang:mainfrom
polina-c:add-note
Open

Explain goal and usage of the table 'Package publishing'.#417
polina-c wants to merge 8 commits into
dart-lang:mainfrom
polina-c:add-note

Conversation

@polina-c
Copy link
Copy Markdown

@polina-c polina-c commented May 31, 2026

Contributes to google/A2UI#1383

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a descriptive message to the package publishing comment in firehose.dart to guide users with publishing permissions, alongside minor code formatting improvements. The review feedback correctly identifies a grammatical typo in the new description string ('this links' instead of 'these links') and provides a code suggestion to correct it.

Comment thread pkgs/firehose/lib/firehose.dart Outdated
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@polina-c polina-c changed the title Add comment that explains goal and usage of the comment. Explain goal and usage of the table 'Package publishing'. May 31, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 31, 2026

PR Health

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Unused Dependencies ✔️
Package Status
firehose ✔️ All dependencies utilized correctly.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
firehose Non-Breaking 0.13.0 0.13.2-wip 0.13.2-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Coverage ⚠️
File Coverage
pkgs/firehose/lib/firehose.dart 💔 0 % ⬇️ NaN %

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

@polina-c
Copy link
Copy Markdown
Author

polina-c commented May 31, 2026

About formatting failure.

This is the bot error:

  dart format --output=none --set-exit-if-changed .
  shell: /usr/bin/bash -e {0}
  env:
    DART_HOME: /opt/hostedtoolcache/dart/3.12.1/x64
    PUB_CACHE: /home/runner/.pub-cache
Changed lib/firehose.dart
Formatted 50 files (1 changed) in 0.10 seconds.

The error does not disappear even after running locally:

dart format pkgs/firehose/lib/firehose.dart

Dart version on bot:

DART_HOME: /opt/hostedtoolcache/dart/3.12.1/x64

My local Dart version:

polinach-mac:ecosystem polinach$ dart --version
Dart SDK version: 3.13.0-149.0.dev (dev) (Fri May 29 01:08:02 2026 -0700) on "macos_arm64"

I also tried older versions of Dart.

Is there more than one flavor of formatting? I suspect yes, because my local dart format made many changes while I changed just two lines.

I reviewed both CONTRIBUTING.md and Dart style guide and did not find guidance.

Will appreciate hints.

@polina-c
Copy link
Copy Markdown
Author

polina-c commented May 31, 2026

@gspencergoog , addressing you feedback about clarity of the comment.

@gspencergoog
Copy link
Copy Markdown

About formatting failure.

Another clue is that the "dev" build succeeds where the "stable" build does not: https://github.com/dart-lang/ecosystem/actions/runs/26720042346/job/78745344376?pr=417

I'm guessing that Dart format changed between the stable and the beta (dev) build. It would be good to figure out what changed, and, if possible, reorganize the offending code so both versions pass (by adding end of line comments, or some other innocuous change).

This is annoying, but I think if we just ignore it, then other people will keep running into it until the next release of Flutter to stable.

I was a little surprised that we use "dev" and not "beta". Maybe that's the beta build anyhow, though, because I thought we stopped releasing dev a long time ago. Anyhow, that could be another source of difference: if the dev build is really an old build that isn't being released anymore, then it also might have a different dart format.

@polina-c
Copy link
Copy Markdown
Author

polina-c commented Jun 1, 2026

... I was a little surprised that we use "dev" and not "beta". Maybe that's the beta build anyhow, though, because I thought we stopped releasing dev a long time ago. Anyhow, that could be another source of difference: if the dev build is really an old build that isn't being released anymore, then it also might have a different dart format.

Good observations. Thanks. I will allow a reviewer from dart-lang to decide if it is ok to ignore the failures.

@gspencergoog
Copy link
Copy Markdown

... I was a little surprised that we use "dev" and not "beta". Maybe that's the beta build anyhow, though, because I thought we stopped releasing dev a long time ago. Anyhow, that could be another source of difference: if the dev build is really an old build that isn't being released anymore, then it also might have a different dart format.

Good observations. Thanks. I will allow a reviewer from dart-lang to decide if it is ok to ignore the failures.

Ahh, but the one thing I didn't observe was that this was in the dart-lang repo. :-) They may very well have a dev release still. It's Flutter that just has beta and stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants