Skip to content

[record_use] Identifiers must only have package uris#3045

Merged
auto-submit[bot] merged 1 commit intomainfrom
document-definition-package-uris
Feb 5, 2026
Merged

[record_use] Identifiers must only have package uris#3045
auto-submit[bot] merged 1 commit intomainfrom
document-definition-package-uris

Conversation

@dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Feb 4, 2026

Bug: #2891

(Needs a PR in the Dart SDK as well to avoid recording things outside package uris.)

@dcharkes dcharkes requested review from goderbauer and mosuem February 4, 2026 15:20
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

PR Health

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/hooks_runner/test_data/download_assets/hook/build.dart
pkgs/jni/test/debug_release_test.dart
pkgs/objective_c/example/command_line/lib/main.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?
record_use Breaking 0.4.2 0.5.0-wip 0.5.0-wip ✔️

This check can be disabled by tagging the PR with skip-breaking-check.

Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcharkes dcharkes force-pushed the remove-use-source-locations branch from 3d227dc to 56555d9 Compare February 5, 2026 13:48
Base automatically changed from remove-use-source-locations to main February 5, 2026 14:05
@dcharkes dcharkes force-pushed the document-definition-package-uris branch from 65c2916 to 1ded08b Compare February 5, 2026 14:10
@coveralls
Copy link

Coverage Status

coverage: 81.008% (+8.8%) from 72.185%
when pulling 1ded08b on document-definition-package-uris
into e359106 on main.

@auto-submit auto-submit bot removed the autosubmit label Feb 5, 2026
@auto-submit
Copy link

auto-submit bot commented Feb 5, 2026

autosubmit label was removed for dart-lang/native/3045, because - The status or check suite build (windows, dev) has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot merged commit 8b9b5a6 into main Feb 5, 2026
62 of 63 checks passed
@auto-submit auto-submit bot deleted the document-definition-package-uris branch February 5, 2026 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants