[infra] apply dot-shorthands#3105
Closed
dcharkes wants to merge 1 commit into
Closed
Conversation
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| code_assets | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:code_assets 1.0.0 (dir=/home/runner/work/native/native/current_repo/pkgs/code_assets). Error: Error: Exception: Missing implementation of visitDotShorthandPropertyAccess |
|
| #0 ThrowingAstVisitor._throw (package:analyzer/dart/ast/visitor.dart:2971:5) | |||||
| #1 ThrowingAstVisitor.visitDotShorthandPropertyAccess (package:analyzer/dart/ast/visitor.dart:2542:7) | |||||
| #2 DotShorthandPropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:5536:15) | |||||
| #3 ResolutionSink._writeNode (package:analyzer/src/summary2/bundle_writer.dart:955:10) | |||||
| #4 ResolutionSink._writeOptionalNode (package:analyzer/src/summary2/bundle_writer.dart:972:7) | |||||
| #5 BundleWriter._writeParameterElement. (package:analyzer/src/summary2/bundle_writer.dart:528:25) | |||||
| #6 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #7 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #8 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #9 BundleWriter._writeParameterElement (package:analyzer/src/summary2/bundle_writer.dart:522:5) | |||||
| #10 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #11 BundleWriter._writeFunctionElement. (package:analyzer/src/summary2/bundle_writer.dart:378:7) | |||||
| #12 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #13 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #14 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #15 BundleWriter._writeFunctionElement (package:analyzer/src/summary2/bundle_writer.dart:376:5) | |||||
| #16 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #17 BundleWriter._writeUnitElement (package:analyzer/src/summary2/bundle_writer.dart:661:5) | |||||
| #18 BundleWriter.writeLibraryElement (package:analyzer/src/summary2/bundle_writer.dart:112:5) | |||||
| #19 Linker._writeLibraries (package:analyzer/src/summary2/link.dart:374:20) | |||||
| #20 Linker.link. (package:analyzer/src/summary2/link.dart:122:7) | |||||
| #21 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #22 Linker.link (package:analyzer/src/summary2/link.dart:121:17) | |||||
| #23 link (package:analyzer/src/summary2/link.dart:43:10) | |||||
| #24 LibraryContext.load.loadBundle. (package:analyzer/src/dart/analysis/library_context.dart:263:22) | |||||
| #25 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #26 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:262:42) | |||||
| #27 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #28 LibraryContext.load. (package:analyzer/src/dart/analysis/library_context.dart:344:7) | |||||
| #29 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #30 LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:343:12) | |||||
| #31 AnalysisDriver._analyzeFileImpl.. (package:analyzer/src/dart/analysis/driver.dart:1376:26) | |||||
| #32 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #33 AnalysisDriver._analyzeFileImpl. (package:analyzer/src/dart/analysis/driver.dart:1375:21) | |||||
| #34 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #35 AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1348:20) | |||||
| #36 AnalysisDriver._analyzeFile. (package:analyzer/src/dart/analysis/driver.dart:1325:9) | |||||
| #37 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #38 AnalysisDriver._analyzeFile (package:analyzer/src/dart/analysis/driver.dart:1322:38) | |||||
| #39 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1217:7) | |||||
| #40 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659:24) | |||||
| data_assets | None | 0.19.6 | 0.19.6 | 0.19.6 | ✔️ |
| hooks | None | 1.0.1 | 1.0.2-wip | 1.0.2-wip | ✔️ |
| hooks_runner | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:hooks_runner 1.1.0-wip (dir=/home/runner/work/native/native/current_repo/pkgs/hooks_runner). Error: Error: Exception: Missing implementation of visitDotShorthandPropertyAccess |
|
| #0 ThrowingAstVisitor._throw (package:analyzer/dart/ast/visitor.dart:2971:5) | |||||
| #1 ThrowingAstVisitor.visitDotShorthandPropertyAccess (package:analyzer/dart/ast/visitor.dart:2542:7) | |||||
| #2 DotShorthandPropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:5536:15) | |||||
| #3 ResolutionSink._writeNode (package:analyzer/src/summary2/bundle_writer.dart:955:10) | |||||
| #4 ResolutionSink._writeOptionalNode (package:analyzer/src/summary2/bundle_writer.dart:972:7) | |||||
| #5 BundleWriter._writeParameterElement. (package:analyzer/src/summary2/bundle_writer.dart:528:25) | |||||
| #6 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #7 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #8 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #9 BundleWriter._writeParameterElement (package:analyzer/src/summary2/bundle_writer.dart:522:5) | |||||
| #10 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #11 BundleWriter._writeFunctionElement. (package:analyzer/src/summary2/bundle_writer.dart:378:7) | |||||
| #12 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #13 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #14 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #15 BundleWriter._writeFunctionElement (package:analyzer/src/summary2/bundle_writer.dart:376:5) | |||||
| #16 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #17 BundleWriter._writeUnitElement (package:analyzer/src/summary2/bundle_writer.dart:661:5) | |||||
| #18 BundleWriter.writeLibraryElement (package:analyzer/src/summary2/bundle_writer.dart:112:5) | |||||
| #19 Linker._writeLibraries (package:analyzer/src/summary2/link.dart:374:20) | |||||
| #20 Linker.link. (package:analyzer/src/summary2/link.dart:122:7) | |||||
| #21 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #22 Linker.link (package:analyzer/src/summary2/link.dart:121:17) | |||||
| #23 link (package:analyzer/src/summary2/link.dart:43:10) | |||||
| #24 LibraryContext.load.loadBundle. (package:analyzer/src/dart/analysis/library_context.dart:263:22) | |||||
| #25 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #26 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:262:42) | |||||
| #27 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #28 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #29 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #30 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #31 LibraryContext.load. (package:analyzer/src/dart/analysis/library_context.dart:344:7) | |||||
| #32 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #33 LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:343:12) | |||||
| #34 AnalysisDriver._analyzeFileImpl.. (package:analyzer/src/dart/analysis/driver.dart:1376:26) | |||||
| #35 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #36 AnalysisDriver._analyzeFileImpl. (package:analyzer/src/dart/analysis/driver.dart:1375:21) | |||||
| #37 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #38 AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1348:20) | |||||
| #39 AnalysisDriver._analyzeFile. (package:analyzer/src/dart/analysis/driver.dart:1325:9) | |||||
| #40 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #41 AnalysisDriver._analyzeFile (package:analyzer/src/dart/analysis/driver.dart:1322:38) | |||||
| #42 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1217:7) | |||||
| #43 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659:24) | |||||
| native_toolchain_c | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:native_toolchain_c 0.17.5-wip (dir=/home/runner/work/native/native/current_repo/pkgs/native_toolchain_c). Error: Error: Exception: Missing implementation of visitDotShorthandPropertyAccess |
|
| #0 ThrowingAstVisitor._throw (package:analyzer/dart/ast/visitor.dart:2971:5) | |||||
| #1 ThrowingAstVisitor.visitDotShorthandPropertyAccess (package:analyzer/dart/ast/visitor.dart:2542:7) | |||||
| #2 DotShorthandPropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:5536:15) | |||||
| #3 ResolutionSink._writeNode (package:analyzer/src/summary2/bundle_writer.dart:955:10) | |||||
| #4 ResolutionSink._writeOptionalNode (package:analyzer/src/summary2/bundle_writer.dart:972:7) | |||||
| #5 BundleWriter._writeParameterElement. (package:analyzer/src/summary2/bundle_writer.dart:528:25) | |||||
| #6 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #7 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #8 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #9 BundleWriter._writeParameterElement (package:analyzer/src/summary2/bundle_writer.dart:522:5) | |||||
| #10 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #11 BundleWriter._writeFunctionElement. (package:analyzer/src/summary2/bundle_writer.dart:378:7) | |||||
| #12 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #13 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #14 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #15 BundleWriter._writeFunctionElement (package:analyzer/src/summary2/bundle_writer.dart:376:5) | |||||
| #16 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #17 BundleWriter._writeUnitElement (package:analyzer/src/summary2/bundle_writer.dart:661:5) | |||||
| #18 BundleWriter.writeLibraryElement (package:analyzer/src/summary2/bundle_writer.dart:112:5) | |||||
| #19 Linker._writeLibraries (package:analyzer/src/summary2/link.dart:374:20) | |||||
| #20 Linker.link. (package:analyzer/src/summary2/link.dart:122:7) | |||||
| #21 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #22 Linker.link (package:analyzer/src/summary2/link.dart:121:17) | |||||
| #23 link (package:analyzer/src/summary2/link.dart:43:10) | |||||
| #24 LibraryContext.load.loadBundle. (package:analyzer/src/dart/analysis/library_context.dart:263:22) | |||||
| #25 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #26 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:262:42) | |||||
| #27 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #28 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #29 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #30 LibraryContext.load. (package:analyzer/src/dart/analysis/library_context.dart:344:7) | |||||
| #31 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #32 LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:343:12) | |||||
| #33 AnalysisDriver._analyzeFileImpl.. (package:analyzer/src/dart/analysis/driver.dart:1376:26) | |||||
| #34 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #35 AnalysisDriver._analyzeFileImpl. (package:analyzer/src/dart/analysis/driver.dart:1375:21) | |||||
| #36 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #37 AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1348:20) | |||||
| #38 AnalysisDriver._analyzeFile. (package:analyzer/src/dart/analysis/driver.dart:1325:9) | |||||
| #39 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #40 AnalysisDriver._analyzeFile (package:analyzer/src/dart/analysis/driver.dart:1322:38) | |||||
| #41 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1217:7) | |||||
| #42 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659:24) | |||||
| record_use | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:record_use 0.5.0-wip (dir=/home/runner/work/native/native/current_repo/pkgs/record_use). Error: Error: RangeError (length): Invalid value: Valid value range is empty: 0 |
This check can be disabled by tagging the PR with skip-breaking-check.
PR Health
Breaking changes
|
| Package | Change | Current Version | New Version | Needed Version | Looking good? |
|---|---|---|---|---|---|
| code_assets | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:code_assets 1.0.0 (dir=/home/runner/work/native/native/current_repo/pkgs/code_assets). Error: Error: Exception: Missing implementation of visitDotShorthandPropertyAccess |
|
| #0 ThrowingAstVisitor._throw (package:analyzer/dart/ast/visitor.dart:2971:5) | |||||
| #1 ThrowingAstVisitor.visitDotShorthandPropertyAccess (package:analyzer/dart/ast/visitor.dart:2542:7) | |||||
| #2 DotShorthandPropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:5536:15) | |||||
| #3 ResolutionSink._writeNode (package:analyzer/src/summary2/bundle_writer.dart:955:10) | |||||
| #4 ResolutionSink._writeOptionalNode (package:analyzer/src/summary2/bundle_writer.dart:972:7) | |||||
| #5 BundleWriter._writeParameterElement. (package:analyzer/src/summary2/bundle_writer.dart:528:25) | |||||
| #6 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #7 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #8 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #9 BundleWriter._writeParameterElement (package:analyzer/src/summary2/bundle_writer.dart:522:5) | |||||
| #10 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #11 BundleWriter._writeFunctionElement. (package:analyzer/src/summary2/bundle_writer.dart:378:7) | |||||
| #12 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #13 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #14 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #15 BundleWriter._writeFunctionElement (package:analyzer/src/summary2/bundle_writer.dart:376:5) | |||||
| #16 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #17 BundleWriter._writeUnitElement (package:analyzer/src/summary2/bundle_writer.dart:661:5) | |||||
| #18 BundleWriter.writeLibraryElement (package:analyzer/src/summary2/bundle_writer.dart:112:5) | |||||
| #19 Linker._writeLibraries (package:analyzer/src/summary2/link.dart:374:20) | |||||
| #20 Linker.link. (package:analyzer/src/summary2/link.dart:122:7) | |||||
| #21 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #22 Linker.link (package:analyzer/src/summary2/link.dart:121:17) | |||||
| #23 link (package:analyzer/src/summary2/link.dart:43:10) | |||||
| #24 LibraryContext.load.loadBundle. (package:analyzer/src/dart/analysis/library_context.dart:263:22) | |||||
| #25 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #26 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:262:42) | |||||
| #27 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #28 LibraryContext.load. (package:analyzer/src/dart/analysis/library_context.dart:344:7) | |||||
| #29 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #30 LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:343:12) | |||||
| #31 AnalysisDriver._analyzeFileImpl.. (package:analyzer/src/dart/analysis/driver.dart:1376:26) | |||||
| #32 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #33 AnalysisDriver._analyzeFileImpl. (package:analyzer/src/dart/analysis/driver.dart:1375:21) | |||||
| #34 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #35 AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1348:20) | |||||
| #36 AnalysisDriver._analyzeFile. (package:analyzer/src/dart/analysis/driver.dart:1325:9) | |||||
| #37 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #38 AnalysisDriver._analyzeFile (package:analyzer/src/dart/analysis/driver.dart:1322:38) | |||||
| #39 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1217:7) | |||||
| #40 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659:24) | |||||
| data_assets | None | 0.19.6 | 0.19.6 | 0.19.6 | ✔️ |
| hooks | None | 1.0.1 | 1.0.1 | 1.0.1 | ✔️ |
| hooks_runner | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:hooks_runner 1.1.0-wip (dir=/home/runner/work/native/native/current_repo/pkgs/hooks_runner). Error: Error: Exception: Missing implementation of visitDotShorthandPropertyAccess |
|
| #0 ThrowingAstVisitor._throw (package:analyzer/dart/ast/visitor.dart:2971:5) | |||||
| #1 ThrowingAstVisitor.visitDotShorthandPropertyAccess (package:analyzer/dart/ast/visitor.dart:2542:7) | |||||
| #2 DotShorthandPropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:5536:15) | |||||
| #3 ResolutionSink._writeNode (package:analyzer/src/summary2/bundle_writer.dart:955:10) | |||||
| #4 ResolutionSink._writeOptionalNode (package:analyzer/src/summary2/bundle_writer.dart:972:7) | |||||
| #5 BundleWriter._writeParameterElement. (package:analyzer/src/summary2/bundle_writer.dart:528:25) | |||||
| #6 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #7 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #8 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #9 BundleWriter._writeParameterElement (package:analyzer/src/summary2/bundle_writer.dart:522:5) | |||||
| #10 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #11 BundleWriter._writeFunctionElement. (package:analyzer/src/summary2/bundle_writer.dart:378:7) | |||||
| #12 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #13 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #14 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #15 BundleWriter._writeFunctionElement (package:analyzer/src/summary2/bundle_writer.dart:376:5) | |||||
| #16 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #17 BundleWriter._writeUnitElement (package:analyzer/src/summary2/bundle_writer.dart:661:5) | |||||
| #18 BundleWriter.writeLibraryElement (package:analyzer/src/summary2/bundle_writer.dart:112:5) | |||||
| #19 Linker._writeLibraries (package:analyzer/src/summary2/link.dart:374:20) | |||||
| #20 Linker.link. (package:analyzer/src/summary2/link.dart:122:7) | |||||
| #21 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #22 Linker.link (package:analyzer/src/summary2/link.dart:121:17) | |||||
| #23 link (package:analyzer/src/summary2/link.dart:43:10) | |||||
| #24 LibraryContext.load.loadBundle. (package:analyzer/src/dart/analysis/library_context.dart:263:22) | |||||
| #25 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #26 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:262:42) | |||||
| #27 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #28 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #29 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #30 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #31 LibraryContext.load. (package:analyzer/src/dart/analysis/library_context.dart:344:7) | |||||
| #32 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #33 LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:343:12) | |||||
| #34 AnalysisDriver._analyzeFileImpl.. (package:analyzer/src/dart/analysis/driver.dart:1376:26) | |||||
| #35 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #36 AnalysisDriver._analyzeFileImpl. (package:analyzer/src/dart/analysis/driver.dart:1375:21) | |||||
| #37 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #38 AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1348:20) | |||||
| #39 AnalysisDriver._analyzeFile. (package:analyzer/src/dart/analysis/driver.dart:1325:9) | |||||
| #40 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #41 AnalysisDriver._analyzeFile (package:analyzer/src/dart/analysis/driver.dart:1322:38) | |||||
| #42 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1217:7) | |||||
| #43 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659:24) | |||||
| native_toolchain_c | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:native_toolchain_c 0.17.5-wip (dir=/home/runner/work/native/native/current_repo/pkgs/native_toolchain_c). Error: Error: Exception: Missing implementation of visitDotShorthandPropertyAccess |
|
| #0 ThrowingAstVisitor._throw (package:analyzer/dart/ast/visitor.dart:2971:5) | |||||
| #1 ThrowingAstVisitor.visitDotShorthandPropertyAccess (package:analyzer/dart/ast/visitor.dart:2542:7) | |||||
| #2 DotShorthandPropertyAccessImpl.accept (package:analyzer/src/dart/ast/ast.dart:5536:15) | |||||
| #3 ResolutionSink._writeNode (package:analyzer/src/summary2/bundle_writer.dart:955:10) | |||||
| #4 ResolutionSink._writeOptionalNode (package:analyzer/src/summary2/bundle_writer.dart:972:7) | |||||
| #5 BundleWriter._writeParameterElement. (package:analyzer/src/summary2/bundle_writer.dart:528:25) | |||||
| #6 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #7 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #8 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #9 BundleWriter._writeParameterElement (package:analyzer/src/summary2/bundle_writer.dart:522:5) | |||||
| #10 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #11 BundleWriter._writeFunctionElement. (package:analyzer/src/summary2/bundle_writer.dart:378:7) | |||||
| #12 BundleWriter._writeTypeParameters. (package:analyzer/src/summary2/bundle_writer.dart:640:8) | |||||
| #13 _LocalElementIndexer.withElements (package:analyzer/src/summary2/bundle_writer.dart:1218:6) | |||||
| #14 BundleWriter._writeTypeParameters (package:analyzer/src/summary2/bundle_writer.dart:638:35) | |||||
| #15 BundleWriter._writeFunctionElement (package:analyzer/src/summary2/bundle_writer.dart:376:5) | |||||
| #16 BundleWriter._writeList (package:analyzer/src/summary2/bundle_writer.dart:430:19) | |||||
| #17 BundleWriter._writeUnitElement (package:analyzer/src/summary2/bundle_writer.dart:661:5) | |||||
| #18 BundleWriter.writeLibraryElement (package:analyzer/src/summary2/bundle_writer.dart:112:5) | |||||
| #19 Linker._writeLibraries (package:analyzer/src/summary2/link.dart:374:20) | |||||
| #20 Linker.link. (package:analyzer/src/summary2/link.dart:122:7) | |||||
| #21 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #22 Linker.link (package:analyzer/src/summary2/link.dart:121:17) | |||||
| #23 link (package:analyzer/src/summary2/link.dart:43:10) | |||||
| #24 LibraryContext.load.loadBundle. (package:analyzer/src/dart/analysis/library_context.dart:263:22) | |||||
| #25 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #26 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:262:42) | |||||
| #27 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #28 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #29 LibraryContext.load.loadBundle (package:analyzer/src/dart/analysis/library_context.dart:153:9) | |||||
| #30 LibraryContext.load. (package:analyzer/src/dart/analysis/library_context.dart:344:7) | |||||
| #31 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #32 LibraryContext.load (package:analyzer/src/dart/analysis/library_context.dart:343:12) | |||||
| #33 AnalysisDriver._analyzeFileImpl.. (package:analyzer/src/dart/analysis/driver.dart:1376:26) | |||||
| #34 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #35 AnalysisDriver._analyzeFileImpl. (package:analyzer/src/dart/analysis/driver.dart:1375:21) | |||||
| #36 PerformanceLog.run (package:analyzer/src/dart/analysis/performance_logger.dart:38:15) | |||||
| #37 AnalysisDriver._analyzeFileImpl (package:analyzer/src/dart/analysis/driver.dart:1348:20) | |||||
| #38 AnalysisDriver._analyzeFile. (package:analyzer/src/dart/analysis/driver.dart:1325:9) | |||||
| #39 OperationPerformanceImpl.run (package:analyzer/src/util/performance/operation_performance.dart:155:23) | |||||
| #40 AnalysisDriver._analyzeFile (package:analyzer/src/dart/analysis/driver.dart:1322:38) | |||||
| #41 AnalysisDriver.performWork (package:analyzer/src/dart/analysis/driver.dart:1217:7) | |||||
| #42 AnalysisDriverScheduler._run (package:analyzer/src/dart/analysis/driver.dart:2659:24) | |||||
| record_use | Breaking | 0.0.0 | 0.0.0 | 0.0.0 Report was not created for package:record_use 0.5.0-wip (dir=/home/runner/work/native/native/current_repo/pkgs/record_use). Error: Error: RangeError (length): Invalid value: Valid value range is empty: 0 |
This check can be disabled by tagging the PR with skip-breaking-check.
License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
| Files |
|---|
| no missing headers |
All source files should start with a license header.
Unrelated files missing license headers
| Files |
|---|
| pkgs/hooks_runner/test_data/download_assets/hook/build.dart |
| pkgs/jni/test/debug_release_test.dart |
| pkgs/objective_c/example/command_line/lib/main.dart |
| pkgs/objective_c/lib/src/ns_input_stream.dart |
This check can be disabled by tagging the PR with skip-license-check.
dcharkes
force-pushed
the
use-dot-shorthands
branch
from
73c0b8a to
0c533f1
Compare
dcharkes
force-pushed
the
use-dot-shorthands
branch
from
0c533f1 to
4d2cd93
Compare
Contributor
|
Can we have a quick discussion with the team at our next sync to see how far we want to take dot shorthands? There are some nice improvements in here, but in some other cases the type information is really far removed now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't have lints yet to apply dot shorthands (dart-lang/sdk#61957). However, we do have Gemini CLI...
I undid all the
.newusages, as I found those unreadable.Note: this PR is AI generated, it might have applied dot shorthands inconsistently. I wanted to look at what the resulted code looks like, and I like it.
Blocked by: