Add a top level equals utility - #1897
Closed
natebosch wants to merge 3 commits into
Closed
Conversation
As a shortcut for the very common `it()..equals` pattern. Any other condition will still need to fall back on `it()..`.
This demonstrates a risk of this method - if other packages add an extension which specialized `equals` for other Subject types, they won't get picked up by `equals()` but would get picked up by `it()..equals()`.
Member
Author
|
If we consider adding something like this after landing #2697 it would be something like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a shortcut for the very common
it()..equalspattern. Any othercondition will still need to fall back on
it()...