Handle objects with empty toString - #2662
Merged
Merged
Conversation
The approach to building text descriptions involves appending and prepending text to string iterables. If the "base" of the string description is an empty iterable it propagates through as empty, which can cause missing lines from the failure output. Add a fallback of `'empty toString()'` in the case any object returns a completely empty string representation.
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with |
Member
Author
|
I noticed this when trying the migration of |
natebosch
added a commit
that referenced
this pull request
Jun 4, 2026
The approach to building text descriptions involves appending and prepending text to string iterables. If the "base" of the string description is an empty iterable it propagates through as empty, which can cause missing lines from the failure output. Add a fallback of `'empty toString()'` in the case any object returns a completely empty string representation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The approach to building text descriptions involves appending and
prepending text to string iterables. If the "base" of the string
description is an empty iterable it propagates through as empty, which
can cause missing lines from the failure output.
Add a fallback of
'empty toString()'in the case any object returns acompletely empty string representation.