Mark AnsiCode and AnsiCodeType final - #2402
Conversation
As discussed in #2297 Eagerly mark these as final to disallow `implements` before landing changes to the API. An internal test run confirmed no google3 use cases rely on the capability.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthLicense Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
This check can be disabled by tagging the PR with Unused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with |
There was a problem hiding this comment.
Code Review
This pull request marks the AnsiCode and AnsiCodeType classes as final to explicitly prevent subclassing and interface implementation, ensuring future API flexibility. These changes are documented in the CHANGELOG as potentially breaking. Feedback was provided to correct a grammatical error in the CHANGELOG description for better readability.
|
|
||
| * Add a `deepCopyLinks` argument to `copyPath` and `copyPathSync`. | ||
| * **Potentially Breaking** `AnsiCode` and `AnsiCodeType` marked final. These | ||
| never intended to support subclasses and were already closed for extension |
There was a problem hiding this comment.
The phrasing "never intended" is missing a verb. It should be "were never intended" to correctly describe the intent behind the classes.
| never intended to support subclasses and were already closed for extension | |
| were never intended to support subclasses and were already closed for extension |
As discussed in #2297
Eagerly mark these as final to disallow
implementsbefore landingchanges to the API.
An internal test run confirmed no google3 use cases rely on the
capability.