Update CODEOWNERS with global fallback and missing packages - #2469
Conversation
Add a global fallback rule for root documentation, config files, and generic tools, and update ownership for third_party/yaml-test-suite, update-yaml-test-suite.sh, and pkgs/api_summary. TAG=agy CONV=f68e2947-130f-4337-a45c-b71facf9688a
Package publishingIf you have publishing permissions, you can use the links below to publish the changes after merging this PR.
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthUnused Dependencies ✔️
For details on how to fix these, see dependency_validator. This check can be disabled by tagging the PR with License Headers ✔️
All source files should start with a license header. This check can be disabled by tagging the PR with API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
This check can be disabled by tagging the PR with Changelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. This check can be disabled by tagging the PR with Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). This check can be disabled by tagging the PR with Breaking changes ✔️
This check can be disabled by tagging the PR with |
There was a problem hiding this comment.
Code Review
This pull request updates the .github/CODEOWNERS file by introducing global ownership, assigning the YAML test suite to the pub team, updating owners for pkgs/cli_util and pkgs/extension_discovery, and adding pkgs/api_summary. The reviewer suggests removing the stale #tbd comment from the pkgs/api_summary entry to keep the file clean.
| third_party/yaml-test-suite @dart-lang/dart-pub-team | ||
| tool/update-yaml-test-suite.sh @dart-lang/dart-pub-team | ||
|
|
||
| pkgs/api_summary @dart-lang/dart-ecosystem-team #tbd |
There was a problem hiding this comment.
The #tbd (to be decided) comment is still present on this line, but the pull request description indicates that ownership for pkgs/api_summary is being updated/resolved. If the ownership has been decided, please remove the #tbd comment to keep the CODEOWNERS file clean and accurate.
pkgs/api_summary @dart-lang/dart-ecosystem-team
There was a problem hiding this comment.
@kevmoo who owns this package? Also, it's not published yet, is that intended?
There was a problem hiding this comment.
It's all me. Paul has given up the reins as long as I promise not to break anything. 🤞
| pkgs/coverage @liamappelbe @dart-lang/dart-native-runtime-team | ||
| pkgs/csslib @dart-lang/dart-ecosystem-team #formerly @leonsenft | ||
| pkgs/extension_discovery @dart-lang/dart-ecosystem-team #tbd | ||
| pkgs/extension_discovery @dart-lang/dart-pub-team |
There was a problem hiding this comment.
it's the same team, and this possibly just as much both teams now.
There was a problem hiding this comment.
it's a different alias here in github still though? We could merge the two.
Add a global fallback rule for root documentation, config files, and generic tools, and update ownership for third_party/yaml-test-suite, update-yaml-test-suite.sh, and pkgs/api_summary.