Skip to content

Update CODEOWNERS with global fallback and missing packages - #2469

Open
mosuem wants to merge 1 commit into
mainfrom
update-codeowners
Open

Update CODEOWNERS with global fallback and missing packages#2469
mosuem wants to merge 1 commit into
mainfrom
update-codeowners

Conversation

@mosuem

@mosuem mosuem commented Jul 16, 2026

Copy link
Copy Markdown
Member

Add a global fallback rule for root documentation, config files, and generic tools, and update ownership for third_party/yaml-test-suite, update-yaml-test-suite.sh, and pkgs/api_summary.

Add a global fallback rule for root documentation, config files, and generic tools,
and update ownership for third_party/yaml-test-suite, update-yaml-test-suite.sh,
and pkgs/api_summary.

TAG=agy
CONV=f68e2947-130f-4337-a45c-b71facf9688a
@mosuem
mosuem requested a review from a team as a code owner July 16, 2026 11:20
@github-actions github-actions Bot added the type-infra A repository infrastructure change or enhancement label Jul 16, 2026
@mosuem
mosuem requested review from dcharkes and jonasfj July 16, 2026 11:21
@github-actions

Copy link
Copy Markdown

Package publishing

If you have publishing permissions, you can use the links below to publish the changes after merging this PR.

Package Version Status Publish tag (post-merge)
package:api_summary 0.1.0-wip WIP (no publish necessary)
package:bazel_worker 1.1.5 already published at pub.dev
package:benchmark_harness 2.4.0 already published at pub.dev
package:boolean_selector 2.1.2 already published at pub.dev
package:browser_launcher 1.2.0-wip WIP (no publish necessary)
package:cli_config 0.2.1-wip WIP (no publish necessary)
package:cli_util 0.5.1 already published at pub.dev
package:clock 1.1.3-wip WIP (no publish necessary)
package:code_builder 4.12.0-wip WIP (no publish necessary)
package:coverage 1.15.1 already published at pub.dev
package:csslib 1.0.2 already published at pub.dev
package:extension_discovery 2.1.0 already published at pub.dev
package:file 7.0.2-wip WIP (no publish necessary)
package:file_testing 3.1.0-wip WIP (no publish necessary)
package:glob 2.1.3 already published at pub.dev
package:graphs 2.4.0-wip WIP (no publish necessary)
package:html 0.15.7-wip WIP (no publish necessary)
package:io 1.1.0-wip WIP (no publish necessary)
package:json_rpc_2 4.1.0 already published at pub.dev
package:markdown 7.4.0 ready to publish markdown-v7.4.0
package:mime 2.1.0-wip WIP (no publish necessary)
package:oauth2 2.0.5 already published at pub.dev
package:package_config 3.0.0 already published at pub.dev
package:pool 1.5.3-wip WIP (no publish necessary)
package:process 5.0.5 (error) pubspec version (5.0.5) and changelog (5.0.6-wip) don't agree
package:pub_semver 2.2.0 already published at pub.dev
package:pubspec_parse 1.6.0-wip WIP (no publish necessary)
package:source_map_stack_trace 2.1.3-wip WIP (no publish necessary)
package:source_maps 0.10.14-wip WIP (no publish necessary)
package:source_span 1.10.2 already published at pub.dev
package:sse 4.2.1-wip WIP (no publish necessary)
package:stack_trace 1.12.2-wip (error) pubspec version (1.12.2-wip) and changelog (1.12.2-dev) don't agree
package:stream_channel 2.1.4 already published at pub.dev
package:stream_transform 2.1.2-wip WIP (no publish necessary)
package:string_scanner 1.4.2-wip WIP (no publish necessary)
package:term_glyph 1.2.3-wip WIP (no publish necessary)
package:test_reflective_loader 0.6.0 ready to publish test_reflective_loader-v0.6.0
package:timing 1.0.2 already published at pub.dev
package:unified_analytics 8.0.16-wip WIP (no publish necessary)
package:watcher 1.2.2-wip WIP (no publish necessary)
package:yaml 3.1.4-wip WIP (no publish necessary)
package:yaml_edit 2.2.4 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@github-actions

Copy link
Copy Markdown

PR Health

Unused Dependencies ✔️
Package Status
None No packages found to check.

For details on how to fix these, see dependency_validator.

This check can be disabled by tagging the PR with skip-unused-dependencies-check.

License Headers ✔️
// Copyright (c) 2026, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.

Files
no missing headers

All source files should start with a license header.

This check can be disabled by tagging the PR with skip-license-check.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbol Leaking sources

This check can be disabled by tagging the PR with skip-leaking-check.

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

Coverage ✔️
File Coverage

This check for test coverage is informational (issues shown here will not fail the PR).

This check can be disabled by tagging the PR with skip-coverage-check.

Breaking changes ✔️
Package Change Current Version New Version Needed Version Looking good?

This check can be disabled by tagging the PR with skip-breaking-check.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the .github/CODEOWNERS file by introducing global ownership, assigning the YAML test suite to the pub team, updating owners for pkgs/cli_util and pkgs/extension_discovery, and adding pkgs/api_summary. The reviewer suggests removing the stale #tbd comment from the pkgs/api_summary entry to keep the file clean.

Comment thread .github/CODEOWNERS
third_party/yaml-test-suite @dart-lang/dart-pub-team
tool/update-yaml-test-suite.sh @dart-lang/dart-pub-team

pkgs/api_summary @dart-lang/dart-ecosystem-team #tbd

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The #tbd (to be decided) comment is still present on this line, but the pull request description indicates that ownership for pkgs/api_summary is being updated/resolved. If the ownership has been decided, please remove the #tbd comment to keep the CODEOWNERS file clean and accurate.

pkgs/api_summary                @dart-lang/dart-ecosystem-team

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevmoo who owns this package? Also, it's not published yet, is that intended?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kevmoo and maybe paul.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that @stereotype441?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's all me. Paul has given up the reins as long as I promise not to break anything. 🤞

Comment thread .github/CODEOWNERS
pkgs/coverage @liamappelbe @dart-lang/dart-native-runtime-team
pkgs/csslib @dart-lang/dart-ecosystem-team #formerly @leonsenft
pkgs/extension_discovery @dart-lang/dart-ecosystem-team #tbd
pkgs/extension_discovery @dart-lang/dart-pub-team

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same team, and this possibly just as much both teams now.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a different alias here in github still though? We could merge the two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-infra A repository infrastructure change or enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants