source_maps: check bounds earlier. - #2483
Open
davidmorgan wants to merge 1 commit into
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds validation to prevent negative source URL and source name IDs during source map parsing in pkgs/source_maps/lib/parser.dart, throwing a StateError if they are out of bounds. It also adds corresponding unit tests in pkgs/source_maps/test/parser_test.dart to verify this behavior. There are no review comments, and I have no additional feedback to provide.
davidmorgan
force-pushed
the
source-maps-bounds
branch
from
July 31, 2026 17:16
61bba2e to
fcac355
Compare
davidmorgan
marked this pull request as ready for review
July 31, 2026 17:18
natebosch
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail earlier if a source map is invalid.
Prepare to release.