ci: split run-action e2e tests by case and consolidate integration tests#171
Merged
Conversation
dash14
marked this pull request as ready for review
July 18, 2026 16:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
runaction's audit-mode restrict-mode-example feature (#170) had no e2e coverage —test-e2e.yml'stest_sandboxjob never exercisedproxy_mode: audit. Digging into why turned up a related gap:run/src/main.js'sactionRef/actionRepofell through to""(notreport/src/main.js's"v2"/"dash14/buildcage"defaults) when invoked via a local path (uses: ./run, as this repo's own e2e tests do), so a local audit-mode run would render a broken-lookinguses: /run@in the generated example instead of something an assertion could actually check.While adding audit-mode coverage, the sandbox e2e/integration tests were also restructured.
test_sandbox's cases (enforcement, writable, fail_on_blocked, concurrency) had been splitting into ever more jobs, each repeating the same checkout/build/rebuild boilerplate, even though only one representative case per input actually needs the real action wrapper. The rest —writable:value variations, privilege-drop/filesystem defaults, direct concurrent proxy lifecycles — don't depend on the action wrapper at all, so they've moved totest-integration.ymlas real shell scripts underrun/test/, run via a singlemake test_sandbox_integrationtarget instead of one GitHub Actions job apiece.Changes
run/src/main.js'sactionRef/actionRepofallback (??→||, with"v2"/"dash14/buildcage"defaults) to mirrorreport/src/main.js's handling of local-pathuses: ./runinvocationscore/lib/build-example.jstest-e2e.yml's sandbox jobs —test_sandbox_audit_mode(new, placed first) verifies the restrict-mode example renders in the Job Summary;test_sandbox_enforcementnow also covers onewritable:pattern in the sameruninvocation instead of a separate job;test_sandbox_fail_on_blockedandtest_sandbox_concurrencyare unchangedtest-integration.yml's sandbox jobs into one (test_sandbox), drivingrun/dist/main.cjsdirectly viamake test_sandbox_integrationand new/renamed scripts underrun/test/(integration-test-writable-dir.sh,integration-test-writable-disabled.sh,integration-test-defaults.sh,integration-test-concurrent.sh— the last renamed fromassert-sandbox-concurrent.sh)test_sandbox_integrationMakefile target and updatedocs/development.md's Makefile command table and stale job references