feat: Combining CoinJoin/DashPay/Ferment functionalities#110
Merged
feat: Combining CoinJoin/DashPay/Ferment functionalities#110
Conversation
…ist_diff_result_with_base_lookup
This reverts commit e3b933c.
# Conflicts: # Cargo.lock # dash-spv-apple-bindings/Cargo.toml # dash-spv-apple-bindings/src/common.rs # dash-spv-apple-bindings/src/tests/checkpoints.rs # dash-spv-apple-bindings/src/tests/listdiff/llmq_rotation.rs # dash-spv-apple-bindings/src/tests/listdiff/llmq_rotation_testnet.rs # dash-spv-apple-bindings/src/tests/listdiff/llmq_verification.rs # dash-spv-apple-bindings/src/tests/listdiff/mainnet_core19.rs # dash-spv-apple-bindings/src/tests/listdiff/masternode_list_saving_to_disk.rs # dash-spv-apple-bindings/src/tests/listdiff/test_mainnet_checkpoints.rs # dash-spv-apple-bindings/src/tests/listdiff/test_quorums_from_dash_core_snapshot.rs # dash-spv-apple-bindings/src/tests/listdiff/testnet_test_retrieving.rs # dash-spv-masternode-processor/src/bindings/address.rs # dash-spv-masternode-processor/src/bindings/masternode.rs # dash-spv-masternode-processor/src/chain/common/chain_type.rs # dash-spv-masternode-processor/src/crypto/byte_util.rs # dash-spv-masternode-processor/src/ffi/callbacks.rs # dash-spv-masternode-processor/src/ffi/unboxer.rs # dash-spv-masternode-processor/src/keys/crypto_data.rs # dash-spv-masternode-processor/src/lib_tests.rs # dash-spv-masternode-processor/src/models/llmq_entry.rs # dash-spv-masternode-processor/src/models/masternode_list.rs # dash-spv-masternode-processor/src/models/mn_list_diff.rs # dash-spv-masternode-processor/src/models/mod.rs # dash-spv-masternode-processor/src/models/quorums_cl_sigs_object.rs # dash-spv-masternode-processor/src/processing/mn_listdiff_result.rs # dash-spv-masternode-processor/src/processing/mod.rs # dash-spv-masternode-processor/src/processing/processor.rs # dash-spv-masternode-processor/src/processing/processor_cache.rs # dash-spv-masternode-processor/src/test_helpers.rs # dash-spv-masternode-processor/src/tests/listdiff/mainnet_reload.rs # dash-spv-masternode-processor/src/tests/listdiff/mainnet_test_invalid_mn_list_root.rs # dash-spv-masternode-processor/src/tests/listdiff/mod.rs # dash-spv-masternode-processor/src/tests/listdiff/test_basic_bls_scheme.rs # dash-spv-masternode-processor/src/tests/listdiff/testnet_core19.rs # dash-spv-masternode-processor/src/tests/mod.rs # dash-spv-masternode-processor/src/types/block.rs # dash-spv-masternode-processor/src/types/coinbase_transaction.rs # dash-spv-masternode-processor/src/types/llmq_entry.rs # dash-spv-masternode-processor/src/types/llmq_indexed_hash.rs # dash-spv-masternode-processor/src/types/llmq_map.rs # dash-spv-masternode-processor/src/types/llmq_snapshot.rs # dash-spv-masternode-processor/src/types/llmq_typed_hash.rs # dash-spv-masternode-processor/src/types/masternode_entry.rs # dash-spv-masternode-processor/src/types/masternode_list.rs # dash-spv-masternode-processor/src/types/mn_list_diff_result.rs # dash-spv-masternode-processor/src/types/qr_info_result.rs # dash-spv-masternode-processor/src/types/quorums_cl_sigs_object.rs # dash-spv-masternode-processor/src/types/transaction.rs # dash-spv-masternode-processor/src/types/transaction_input.rs # dash-spv-masternode-processor/src/types/transaction_output.rs # dash-spv-masternode-processor/src/util/java.rs
# Conflicts: # .cargo/config.toml # .gitignore # Cargo.lock # Cargo.toml # dash-spv-apple-bindings/Cargo.toml # dash-spv-apple-bindings/build.rs # dash-spv-apple-bindings/src/fermented.rs # dash-spv-apple-bindings/src/lib.rs # dash-spv-masternode-processor/Cargo.toml # dash-spv-masternode-processor/src/bindings/common.rs # dash-spv-masternode-processor/src/bindings/keys.rs # dash-spv-masternode-processor/src/bindings/masternode.rs # dash-spv-masternode-processor/src/common/socket_address.rs # dash-spv-masternode-processor/src/consensus/encode.rs # dash-spv-masternode-processor/src/keys/bls_key.rs # dash-spv-masternode-processor/src/keys/ecdsa_key.rs # dash-spv-masternode-processor/src/keys/ed25519_key.rs # dash-spv-masternode-processor/src/keys/key.rs # dash-spv-masternode-processor/src/keys/mod.rs # dash-spv-masternode-processor/src/lib.rs # dash-spv-masternode-processor/src/models/llmq_entry.rs # dash-spv-masternode-processor/src/models/masternode_entry.rs # dash-spv-masternode-processor/src/models/masternode_list.rs # dash-spv-masternode-processor/src/processing/processor.rs # dash-spv-masternode-processor/src/tests/bindings/keys.rs # dash-spv-masternode-processor/src/tx/transaction.rs
…e only header file
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
pankcuf
changed the title
Member
|
Looks good as far as CoinJoin changes are concerned. |
Syn-McJ
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combining DashPay + Coinjoin
There are a lot of changes.
Cargo Configuration and Dependencies:
Cargo.toml, includingdash-spv-coinjoin,dash-spv-crypto,dash-spv-event-bus, and more. [1] [2]dash-spv-apple-bindings/Cargo.tomlto version0.5.1and added several new dependencies such asanyhow,bincode_derive,byte, and others.Build Scripts:
build.rsto integrateferment_sysand updated the build process to handle different profiles and external crates.build.shto support both release and debug builds, added target checks, and streamlined the build process for multiple Apple platforms. [1] [2]Podspec and Gitignore:
DashSharedCore.podspecto version0.5.0and adjusted the source file paths to reflect the new target directories. [1] [2].gitignoreto include the.cargodirectory and removed unnecessary entries.Additional Changes:
README.mdwith additional instructions for compiling in debug mode and troubleshooting compilation issues.cbindgen.tomlconfiguration to include new dependencies and updated parsing and binding settings.