Skip to content

feat: make wallet events atomic #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
QuantumExplorer merged 8 commits into from
Apr 28, 2026

fix: backfill missing transaction record in InstantSend path

3e38f00
Select commit
Loading
Failed to load commit list.
Merged

feat: make wallet events atomic #696

fix: backfill missing transaction record in InstantSend path
3e38f00
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 28, 2026 in 0s

70.22% (-0.25%) compared to 659a6d5

View this Pull Request on Codecov

70.22% (-0.25%) compared to 659a6d5

Details

Codecov Report

❌ Patch coverage is 66.41651% with 179 lines in your changes missing coverage. Please review.
✅ Project coverage is 70.22%. Comparing base (659a6d5) to head (3e38f00).
⚠️ Report is 1 commits behind head on v0.42-dev.

Files with missing lines Patch % Lines
dash-spv-ffi/src/bin/ffi_cli.rs 0.00% 55 Missing ⚠️
key-wallet-ffi/src/managed_account.rs 48.07% 54 Missing ⚠️
key-wallet-ffi/src/types.rs 36.36% 21 Missing ⚠️
key-wallet-manager/src/events.rs 0.00% 21 Missing ⚠️
dash-spv-ffi/src/callbacks.rs 81.35% 11 Missing ⚠️
key-wallet-ffi/src/account.rs 10.00% 9 Missing ⚠️
key-wallet-ffi/src/address_pool.rs 40.00% 3 Missing ⚠️
key-wallet-ffi/src/wallet.rs 0.00% 3 Missing ⚠️
key-wallet-manager/src/process_block.rs 98.94% 1 Missing ⚠️
...allet/managed_wallet_info/wallet_info_interface.rs 95.45% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           v0.42-dev     #696      +/-   ##
=============================================
- Coverage      70.47%   70.22%   -0.25%     
=============================================
  Files            319      319              
  Lines          66613    66899     +286     
=============================================
+ Hits           46946    46983      +37     
- Misses         19667    19916     +249
Files with missing lines Coverage Δ
key-wallet-ffi/src/account_collection.rs 56.62% <100.00%> (+1.04%) ⬆️
key-wallet-ffi/src/transaction_checking.rs 1.90% <ø> (ø)
key-wallet-manager/src/accessors.rs 51.21% <100.00%> (-10.66%) ⬇️
key-wallet-manager/src/lib.rs 60.64% <100.00%> (-0.37%) ⬇️
key-wallet-manager/src/test_helpers.rs 100.00% <ø> (ø)
key-wallet/src/managed_account/mod.rs 55.12% <100.00%> (+0.06%) ⬆️
...y-wallet/src/managed_account/transaction_record.rs 100.00% <100.00%> (ø)
...wallet/src/transaction_checking/account_checker.rs 67.02% <100.00%> (+0.51%) ⬆️
...-wallet/src/transaction_checking/wallet_checker.rs 99.34% <100.00%> (+0.05%) ⬆️
key-wallet-manager/src/process_block.rs 92.92% <98.94%> (+1.22%) ⬆️
... and 9 more

... and 18 files with indirect coverage changes

View more details on Codecov