Conversation
There was a problem hiding this comment.
Pull request overview
This pull request attempts to update the project from .NET 8.0 to .NET 10.0 and addresses deprecation warnings in the codebase. However, there is a critical issue: .NET 10.0 does not exist as of January 2026 (the latest stable version is .NET 9.0).
- Updated target framework from net8.0 to net10.0 in both project files
- Replaced deprecated
IHostingEnvironmentwithIWebHostEnvironmentin Startup.cs - Updated
IHeaderDictionary.Add()to useAppend()method to resolve deprecation warning
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| NEasyAuthMiddleware/NEasyAuthMiddleware.csproj | Updated target framework to net10.0 (non-existent version) |
| NEasyAuthMiddleware.Sample/NEasyAuthMiddleware.Sample.csproj | Updated target framework to net10.0 (non-existent version) |
| NEasyAuthMiddleware.Sample/Startup.cs | Replaced deprecated IHostingEnvironment with IWebHostEnvironment and updated using statements |
| NEasyAuthMiddleware.Sample/CustomHeaderDictionaryTransformer.cs | Replaced deprecated Add() with Append() method, removed unused using statements, and fixed formatting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update for dotnet 10.
I fixed a couple of deprecation warnings, all else is as is was (fine and very much in working in order!).
I did not change the version number to 4, I'd leave that up to you.
Thanks for the great project.