Conversation
rjzamora
reviewed
May 9, 2023
Comment on lines
+126
to
+127
| lambda df: df.isna(), | ||
| lambda df: df.x.isna(), |
Member
There was a problem hiding this comment.
We may want pdf to have at least one null for features like this. Or perhaps we have a pdf_nulls fixture?
rjzamora
approved these changes
May 10, 2023
Member
rjzamora
left a comment
rjzamora
left a comment
There was a problem hiding this comment.
Thanks @jrbourbeau - We can add null testing in a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This looked like an easy thing to try and add when looking at failures over in coiled/benchmarks#837. It took about 5 minutes minutes to figure out what to do and write a test (kudos on making things modular). Let me know if I missed something or if this is just totally wrong