Skip to content

Conversation

@nadzhou
Copy link
Contributor

@nadzhou nadzhou commented Dec 6, 2025

Closes #xxxx

  • Tests added / passed
  • Passes pre-commit run --all-files

Closes #2007 since other classes have been implemented. Happy to get feedback on this.

@nadzhou nadzhou requested a review from fjetter as a code owner December 6, 2025 02:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2025

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    31 files  ±  0      31 suites  ±0   11h 23m 5s ⏱️ + 3m 54s
 4 133 tests + 20   4 027 ✅ + 20    104 💤 ±0  2 ❌ ±0 
59 936 runs  +300  57 460 ✅ +301  2 474 💤  - 1  2 ❌ ±0 

For more details on these failures, see this check.

Results for commit 938568c. ± Comparison against base commit 4fb4814.

♻️ This comment has been updated with latest results.

@nadzhou nadzhou marked this pull request as draft December 6, 2025 06:19
Copy link
Member

@jacobtomlinson jacobtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a quick glance this seems fine. The CI is hanging on these new tests though so you'll need to take a look at that.

Once you get things running feel free to ping for a review.

@nadzhou
Copy link
Contributor Author

nadzhou commented Dec 14, 2025

At a quick glance this seems fine. The CI is hanging on these new tests though so you'll need to take a look at that.

Once you get things running feel free to ping for a review.

Thanks for the reply. Sure let me take a look at this.

@nadzhou nadzhou force-pushed the add-condition-primitive branch from 34f5cb4 to b16e6fb Compare December 14, 2025 20:47
@nadzhou nadzhou force-pushed the add-condition-primitive branch from 470135a to 2a34eb0 Compare December 21, 2025 22:31
@nadzhou nadzhou marked this pull request as ready for review February 8, 2026 22:15
@nadzhou
Copy link
Contributor Author

nadzhou commented Feb 8, 2026

Could you take a look @jacobtomlinson?

Just as a disclaimer, I did use Claude to help me with the Condition class. The idea of the waiter_id is suggested by it. If there are potential issues, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Semaphore, Condition, Event

5 participants