Fix masked array deserialization overflow for integer dtypes #9193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NumPy masked arrays default to a fill value of 999999, which cannot be represented by small integer dtypes such as uint8 or uint16. During distributed deserialization this raises a TypeError when reconstructing the masked array and may cause tasks to hang indefinitely. Ensure that fill values are cast safely to the target dtype, falling back to NumPy's default fill value when necessary.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ±0 31 suites ±0 11h 15m 33s ⏱️ - 8m 52s For more details on these failures, see this check. Results for commit 8866074. ± Comparison against base commit 4fb4814. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NumPy masked arrays default to a fill value of 999999, which cannot be
represented by small integer dtypes such as uint8 or uint16.
During distributed deserialization, this raises a TypeError when
reconstructing the masked array and may cause tasks to hang indefinitely.
Ensure that fill values are safely cast to the target dtype, falling back
to NumPy's default fill value when necessary.
Closes #12260
pre-commit run --all-files