Skip to content

Fix ISO 8601 date pattern accepting impossible month/day values #2113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jichaowang02-lang wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −1
Open

Fix ISO 8601 date pattern accepting impossible month/day values #2113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion presidio-analyzer/presidio_analyzer/predefined_recognizers/generic/date_recognizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class DateRecognizer(PatternRecognizer):
PATTERNS = [
Pattern(
"ISO 8601 datetime",
r"\b(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d\.\d+([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))\b",
r"\b(\d{4}-(?:0[1-9]|1[0-2])-(?:0[1-9]|[12]\d|3[01])T[0-2]\d:[0-5]\d:[0-5]\d\.\d+([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-(?:0[1-9]|1[0-2])-(?:0[1-9]|[12]\d|3[01])T[0-2]\d:[0-5]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))|(\d{4}-(?:0[1-9]|1[0-2])-(?:0[1-9]|[12]\d|3[01])T[0-2]\d:[0-5]\d([+-][0-2]\d:[0-5]\d|Z))\b",
0.8,
),
Pattern(
Expand Down
5 changes: 5 additions & 0 deletions presidio-analyzer/tests/test_date_recognizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,11 @@ def entities():
("Today is 2024-03-15T14:30:00Z\r or not?", 1, ((9, 29),), ((0.6, 0.81),),),
("Today is 2024-03-15T14:30Z\n or not?", 1, ((9, 26),), ((0.6, 0.81),),),
("2024-03-15T14:30Z", 1, ((0, 17),), ((0.6, 1),),),
# Invalid ISO 8601 month/day values must not be detected as a date
("2024-13-15T14:30:00Z", 0, (), (),),
("2024-00-15T14:30:00Z", 0, (), (),),
("2024-12-32T14:30Z", 0, (), (),),
("2024-12-00T14:30Z", 0, (), (),),
("Today is2024-06-05T09:15:30.500-07:00", 0, (), (),),
# Word boundary tests
("Today is5/21", 0, (), (),),
Expand Down