fix(analyzer): normalize case before fi hetu and sg uen checksums#2141
Open
uwezkhan wants to merge 1 commit into
Open
fix(analyzer): normalize case before fi hetu and sg uen checksums#2141uwezkhan wants to merge 1 commit into
uwezkhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
validate_resultin two recognizers compares a check character against an upper-case reference without normalizing case. Patterns are matched withregex.IGNORECASE, so a valid ID written with a lower-case letter matches the pattern but is then dropped by the checksum, so the entity is not returned.FiPersonalIdentityCodeRecognizercompares the HETU control character against"0123456789ABCDEFHJKLMNPRSTUVWXY".SgUenRecognizercompares the UEN prefix, entity-type and check letter against upper-case tables (all three formats).Before:
131052-308tand53125226dmatch the regex, fail validation, and are not detected.After: the check character is upper-cased before the comparison, so both detect at the same span and score as their upper-case forms. Invalid checksums stay rejected, so no new false positives.
Same normalization #2076 applied to the ES NIF/NIE recognizers. Added lower-case regression cases to both recognizer test files.
Issue reference
No existing issue.
Checklist