This repository was archived by the owner on Apr 14, 2021. It is now read-only.
closes #54 - Issue with globe disappearing on window resize#55
Open
csavage1994 wants to merge 1 commit intodataarts:masterfrom
Open
closes #54 - Issue with globe disappearing on window resize#55csavage1994 wants to merge 1 commit intodataarts:masterfrom
csavage1994 wants to merge 1 commit intodataarts:masterfrom
Conversation
Contributor
|
How about copying what's done in w = container.offsetWidth || window.innerWidth;
h = container.offsetHeight || window.innerHeight;
camera.aspect = w / h;
camera.updateProjectionMatrix();
renderer.setSize( w, h ); |
animo9205
approved these changes
Apr 9, 2017
erikjames247
approved these changes
Jul 24, 2017
|
Hmm... Still hangs on loading.gif when I resize the window with these changes. |
nitrogl
added a commit
to nitrogl/webgl-globe
that referenced
this pull request
Aug 7, 2020
from a pull request dataarts#55 devaart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the master branch of this repo, any time the window is resized the globe will disappear. The issue persisted across Chrome and Safari. There was a PR that was merged which caused this problem, so the changes I made were to revert the faulty code.