Break out why a DABs deployment is or is not DMS compatible#5668
Open
shreyas-goenka wants to merge 4 commits into
Open
Break out why a DABs deployment is or is not DMS compatible#5668shreyas-goenka wants to merge 4 commits into
shreyas-goenka wants to merge 4 commits into
Conversation
The merged dms_compat_* verdict tells us whether a deploy is auto-migration compatible, but not why. This adds an independent boolean breakdown recorded on every deploy so the population can be sliced directly: - permissions_section_set: separates the always-compatible no-permissions population from declared-permissions deploys (both land on dms_compat_auto). - state_path_in_deployer_home / state_path_in_other_user_home: where the deployment state lives (with the existing state_path_is_shared; all false means some other /Workspace folder). - dms_undeclared_deploying_user / _other_user / _service_principal / _group: which principal types hold undeclared write access to the state folder — the access an auto-migration governed by the permissions section would drop. These co-occur. All keys go through the existing BoolValues map, so no telemetry proto change is needed. Exact per-type counts would need a numeric proto field and are left out. Covered by the existing deploy-workspace-folder-permissions acceptance test (extended with an other-user-home target) plus unit tests for the principal-type classification and home-owner parsing. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
changed the title
Collaborator
Integration test reportCommit: 3e98421
21 interesting tests: 13 SKIP, 7 KNOWN, 1 flaky
Top 20 slowest tests (at least 2 minutes):
|
The deployer != "" guard on state_path_in_deployer_home was redundant — userHomeOwner returns a non-empty owner whenever the path is under a user home, so an unresolved deployer can never match. Drop it so the deployer/other-user home flags are exact complements, and document the invariant. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
commented
Jun 22, 2026
| // initialize phase (before this deploy-phase mutator) and rewrites a bare /Users/... | ||
| // to /Workspace/Users/..., so the /Workspace/Users/ check below is sufficient. | ||
| func userHomeOwner(path string) (owner string, ok bool) { | ||
| const prefix = "/Workspace/Users/" |
Contributor
Author
There was a problem hiding this comment.
Workspace paths will always have the /Workspace prefix by this point. See PrependWorkspacePrefix
Completes the state-folder location breakdown with an explicit bucket for any /Workspace folder that is neither a user home nor shared, so exactly one of the four location keys is true per deploy without deriving "other" by elimination. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
requested review from
andrewnester,
denik and
pietern
and removed request for
andrewnester and
pietern
Contributor
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR helps us get more granular data for why a bundle might or might not be DMS compatible.