Skip to content

refactor ppo callback to move its logic to single controller (part 1)#115

Merged
bowenyang008 merged 110 commits intomainfrom
boweny/single-controller-composer
Jul 29, 2025
Merged

refactor ppo callback to move its logic to single controller (part 1)#115
bowenyang008 merged 110 commits intomainfrom
boweny/single-controller-composer

Conversation

@bowenyang008
Copy link
Collaborator

@bowenyang008 bowenyang008 commented Jul 23, 2025

This is a series of efforts of moving controller logic from callback to a top level single controller, this part 1 does:

  1. Update a couple ppo functions to fix bugs and make them static for sharing
  2. Organize single controller to different actor groups
  3. Refactor logic from callback to single controller
  4. Create a simpler single controller callback just for dataloader and reward calculation (this should be moved to single controller as well in part 2)

@bowenyang008 bowenyang008 marked this pull request as ready for review July 26, 2025 00:21
Copy link
Collaborator

@jdchang1 jdchang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

Copy link
Collaborator

@rithwik-db rithwik-db left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

Copy link
Collaborator

@abaheti95 abaheti95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@bowenyang008 bowenyang008 enabled auto-merge (squash) July 29, 2025 06:56
@bowenyang008 bowenyang008 merged commit b1ed6bd into main Jul 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants