Skip to content

fix: std.manifestYamlDoc passes through Unicode characters natively #1017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
He-Pin wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −2
Open

fix: std.manifestYamlDoc passes through Unicode characters natively #1017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25de3c9
fix: std.manifestYamlDoc passes through Unicode characters natively
He-Pin Jun 24, 2026
cbb79c1
test: add YAML Unicode native output regression test (golden from C++…
He-Pin Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sjsonnet/src/sjsonnet/YamlRenderer.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class YamlRenderer(
null,
YamlRenderer.this.elemBuilder,
s,
escapeUnicode = true,
escapeUnicode = false,
wrapQuotes = true
)
} else {
Expand Down Expand Up @@ -65,7 +65,7 @@ class YamlRenderer(
null,
elemBuilder,
s,
escapeUnicode = true,
escapeUnicode = false,
wrapQuotes = true
)
}
Expand Down
9 changes: 9 additions & 0 deletions sjsonnet/test/resources/new_test_suite/yaml_unicode_native_output.jsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// Regression test: YAML output must pass through Unicode natively.
// Golden verified against cpp-jsonnet 0.21.0, go-jsonnet 0.22.0, jrsonnet 0.5.0-pre99.
std.assertEqual(std.manifestYamlDoc("世界"), "\"世界\"") &&
std.assertEqual(std.manifestYamlDoc("café"), "\"café\"") &&
std.assertEqual(std.manifestYamlDoc({name: "世界", drink: "café"}),
"\"drink\": \"café\"\n\"name\": \"世界\"") &&
std.assertEqual(std.manifestYamlDoc(["🌍", "世界", "café"]),
"- \"🌍\"\n- \"世界\"\n- \"café\"") &&
true
1 change: 1 addition & 0 deletions sjsonnet/test/resources/new_test_suite/yaml_unicode_native_output.jsonnet.golden
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
true
Loading