This repository was archived by the owner on Dec 20, 2018. It is now read-only.
Make "createConverterToAvro" function public static#220
Open
ovj wants to merge 2 commits intodatabricks:masterfrom
Open
Make "createConverterToAvro" function public static#220ovj wants to merge 2 commits intodatabricks:masterfrom
ovj wants to merge 2 commits intodatabricks:masterfrom
Conversation
…essed outside of AvroOutputWriter
Codecov Report
@@ Coverage Diff @@
## master #220 +/- ##
==========================================
- Coverage 90.4% 89.96% -0.44%
==========================================
Files 5 5
Lines 323 329 +6
Branches 49 52 +3
==========================================
+ Hits 292 296 +4
- Misses 31 33 +2Continue to review full report at Codecov.
|
|
Wouldn't it make sense to change the access modifiers on all these schema conversion functions? We have lots of AVRO encoded data that is not accessible via a filesystem path (stored in Redis/RDBMS/etc) that we'd love to transform into Dataframes and vice versa. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will help createConverterToAvro being used outside of AvroOutputWriter.