Skip to content

[Internal] Host Agnostic Unified Provider#5547

Open
tanmay-db wants to merge 6 commits intomainfrom
host-agnostic-unified-2
Open

[Internal] Host Agnostic Unified Provider#5547
tanmay-db wants to merge 6 commits intomainfrom
host-agnostic-unified-2

Conversation

@tanmay-db
Copy link
Copy Markdown
Contributor

@tanmay-db tanmay-db commented Mar 31, 2026

Changes

Makes the unified provider host agnostic by unifying GetWorkspaceClientForUnifiedProvider into a single flow that works identically for workspace, account, and unified host configurations.

Previously, the function branched on HostType() to select between two separate code paths with duplicated validation logic. Now, a single flow handles all host types — it tries the provider's workspace client first, validates when possible, and falls through to account API resolution when the provider doesn't know its own workspace ID.

Also simplified NamespaceValidateWorkspaceID to delegate to the same unified flow.

Tests

  • Unit tests
  • Integration tests

NO_CHANGELOG=true

@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 31, 2026 09:13 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 31, 2026 09:14 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 31, 2026 09:15 — with GitHub Actions Inactive
@tanmay-db tanmay-db marked this pull request as ready for review March 31, 2026 12:58
@tanmay-db tanmay-db requested review from a team as code owners March 31, 2026 12:58
@tanmay-db tanmay-db requested review from tejaskochar-db and removed request for a team and tejaskochar-db March 31, 2026 12:58
@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 31, 2026 18:34 — with GitHub Actions Inactive
@tanmay-db tanmay-db temporarily deployed to test-trigger-is March 31, 2026 18:35 — with GitHub Actions Inactive
@tanmay-db tanmay-db force-pushed the host-agnostic-unified-2 branch from 0a0da3d to 8ad05f1 Compare April 1, 2026 08:48
@tanmay-db tanmay-db temporarily deployed to test-trigger-is April 7, 2026 11:51 — with GitHub Actions Inactive
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

If integration tests don't run automatically, an authorized user can run them manually by following the instructions below:

Trigger:
go/deco-tests-run/terraform

Inputs:

  • PR number: 5547
  • Commit SHA: 7d2b69e40f9ff36d71bd6f3f00e321a817136aec

Checks will be approved automatically on success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants