Skip to content

Fix invisible picker rows on light-mode terminals#166

Merged
asujithan merged 1 commit into
mainfrom
asujithan/fix-light-mode-terminal
Jun 18, 2026
Merged

Fix invisible picker rows on light-mode terminals#166
asujithan merged 1 commit into
mainfrom
asujithan/fix-light-mode-terminal

Conversation

@asujithan

Copy link
Copy Markdown
Collaborator

Fix #159

Drop the fg:white overrides in both pickers' styles. Use noinherit alone for highlighted and selected, which strips prompt_toolkit's default per-row highlight without applying any colour of its own. The only colour signals left:

  • Cursor row → cyan › pointer
  • Selected rows → filled ● vs empty ○ circle
    Row text always renders in the terminal's default foreground, so the list is readable on both light and dark themes.

Changes

  • src/ucode/ui.py — prompt_for_tools style
  • src/ucode/mcp.py — _picker_style (shared across MCP pickers)

Test plan

  • uv run ruff check .
  • uv run pytest
  • Manual: ucode configure and ucode configure mcp on a light terminal — all rows visible, cursor/selection signals work
  • Manual: same flows on a dark terminal — no regression

@asujithan asujithan requested a review from AarushiShah-db June 16, 2026 17:28
@asujithan asujithan merged commit 18c9a06 into main Jun 18, 2026
4 of 6 checks passed
@asujithan asujithan deleted the asujithan/fix-light-mode-terminal branch June 18, 2026 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

the harness picker doesn't show the harnesses in a lightmode iterm2 terminal

2 participants