Skip to content

Update lock-dependencies to also scrub the registry used in CDN URLs.#2525

Open
asnare wants to merge 3 commits into
mainfrom
fix/lock-dependencies
Open

Update lock-dependencies to also scrub the registry used in CDN URLs.#2525
asnare wants to merge 3 commits into
mainfrom
fix/lock-dependencies

Conversation

@asnare

@asnare asnare commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

This PR updates the lock-dependencies mechanism so that scrubbing also takes care of the CDN URLs that are embedded in there; some mirrors/proxies, in addition to rewriting the registry, also rewrite the URLs.

Caveats/things to watch out for when reviewing:

The lint-uv check will fail, but can be safely ignored/overridden to merge.

Linked issues

Relates: databrickslabs/blueprint#392

Functionality

  • updates make lock-dependencies

Tests

  • manually tested: produces the uv.lock included in this PR.
  • automated CI checks the resulting lock-file.

@asnare asnare self-assigned this Jun 23, 2026
@asnare asnare requested a review from a team as a code owner June 23, 2026 15:48
@asnare asnare added bug Something isn't working dependencies Pull requests that update a dependency file internal technical pr's not end user facing labels Jun 23, 2026
@databrickslabs databrickslabs deleted a comment from CLAassistant Jun 23, 2026
@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.88%. Comparing base (980e85f) to head (edd152a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2525   +/-   ##
=======================================
  Coverage   68.88%   68.88%           
=======================================
  Files         104      104           
  Lines        9476     9476           
  Branches     1050     1050           
=======================================
  Hits         6528     6528           
  Misses       2755     2755           
  Partials      193      193           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jun 23, 2026

Copy link
Copy Markdown

✅ 169/169 passed, 8 flaky, 2 skipped, 1h20m35s total

Flaky tests:

  • 🤪 test_installs_and_runs_local_bladebridge (12.604s)
  • 🤪 test_installs_and_runs_pypi_bladebridge (23.292s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[True] (23.506s)
  • 🤪 test_transpile_teradata_sql_non_interactive[True] (25.659s)
  • 🤪 test_transpile_teradata_sql (27.065s)
  • 🤪 test_transpile_teradata_sql_non_interactive[False] (5.716s)
  • 🤪 test_transpiles_informatica_to_sparksql (25.096s)
  • 🤪 test_transpiles_informatica_to_sparksql_non_interactive[False] (22.83s)

Running from acceptance #4909

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Pull requests that update a dependency file internal technical pr's not end user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant