Fix failing unit tests#282
Merged
Merged
Conversation
|
✅ 40/40 passed, 6 skipped, 14m20s total Running from acceptance #253 |
m-abulazm
reviewed
Jun 23, 2026
m-abulazm
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR works around a behaviour change introduced by Databricks SDK v0.102.0 that causes unit tests to fail if they are using the
Configclass. Specifically, during__init__()theConfig()class now performs a HTTP request against the host, and retries for 5 minutes if the host does not exist.Unit tests typically fill in a bogus host, which was fine previously because initialising
Configwas inert and didn't trigger network calls. Now that it does, some sort of workaround (such as monkey-patching) is required.Incidental change:
Linked issues
Tests, same as: databrickslabs/blueprint#331
For
Makefile, same as: databrickslabs/blueprint#392Tests