Skip to content

Fix wheel and sdist build configuration#4828

Open
asnare wants to merge 2 commits into
mainfrom
fix/packaging
Open

Fix wheel and sdist build configuration#4828
asnare wants to merge 2 commits into
mainfrom
fix/packaging

Conversation

@asnare

@asnare asnare commented May 11, 2026

Copy link
Copy Markdown
Contributor

Changes

This PR updates the project configuration so that the source distribution properly contains the files needed to build the wheel.

Linked issues

For more context refer to databrickslabs/lakebridge#2419.

Functionality

  • update project packaging

Tests

  • manually tested: make build and examined the produced source and wheel distributions

@asnare asnare self-assigned this May 11, 2026
@asnare asnare added this to UCX May 11, 2026
@asnare asnare added the internal this pull request won't appear in release notes label May 11, 2026
@asnare asnare requested a review from a team as a code owner May 11, 2026 09:04
@asnare asnare added the bug label May 11, 2026
@asnare asnare temporarily deployed to account-admin May 11, 2026 09:04 — with GitHub Actions Inactive
@asnare asnare moved this to Ready for Review in UCX May 11, 2026
@asnare asnare added the tech debt chores and design flaws label May 11, 2026
@github-actions

github-actions Bot commented May 11, 2026

Copy link
Copy Markdown

✅ 2/2 passed, 21s total

Running from acceptance #9043

@codecov

codecov Bot commented May 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.79%. Comparing base (4451cbe) to head (4fa1f72).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4828      +/-   ##
==========================================
- Coverage   87.79%   87.79%   -0.01%     
==========================================
  Files         123      123              
  Lines       17595    17595              
  Branches     3717     3717              
==========================================
- Hits        15448    15447       -1     
  Misses       1458     1458              
- Partials      689      690       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@asnare asnare changed the title Fix source distribution packaging so that wheel can be properly built. Fix wheel and sdist build configuration May 11, 2026
@asnare asnare deployed to account-admin June 12, 2026 13:19 — with GitHub Actions Active
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug internal this pull request won't appear in release notes tech debt chores and design flaws

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

2 participants